Bug 37217

Summary: Add skeleton FileStream module for providing sync file operations for FileAPI
Product: WebKit Reporter: Kinuko Yasuda <kinuko>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dimich, ericu, fishd, jeffschiller, jianli
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 32624, 36567, 37218    
Attachments:
Description Flags
Patch
none
Patch jianli: review+, jianli: commit-queue-

Kinuko Yasuda
Reported 2010-04-07 10:26:17 PDT
We need a platform-independent module that supports synchronous file operations for FileAPI. The operations provided by FileStream are supposed to run on worker or file threads.
Attachments
Patch (16.37 KB, patch)
2010-04-07 10:35 PDT, Kinuko Yasuda 		no flags
DetailsFormatted DiffDiff
Patch (17.79 KB, patch)
2010-04-07 11:26 PDT, Kinuko Yasuda 		jianli: review+
jianli: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kinuko Yasuda
Comment 1 2010-04-07 10:35:55 PDT
Created attachment 52750 [details] Patch
Jian Li
Comment 2 2010-04-07 10:53:33 PDT
Comment on attachment 52750 [details] Patch You need to add new files to other projects, like the following: WebCore.vcproj/WebCore.vcproj WebCore.gypi WebCore.pro GNUmakefile.am Also you do not need to list all the new methods for the new files in ChangeLog.
Kinuko Yasuda
Comment 3 2010-04-07 11:26:11 PDT
Created attachment 52759 [details] Patch
Kinuko Yasuda
Comment 4 2010-04-07 11:37:37 PDT
Comment on attachment 52759 [details] Patch Thanks, updated the patch (so did I for 37218).
Jian Li
Comment 5 2010-04-07 13:20:45 PDT
Comment on attachment 52759 [details] Patch Looks good. Need to land it manually due to potential xcodeproj conflict when applying the patch. r=me
Jian Li
Comment 6 2010-04-07 13:50:30 PDT
Landed for kinuko at http://trac.webkit.org/changeset/57229.
Note You need to log in before you can comment on or make changes to this bug.