Bug 35376

Summary: Add support for mingw 64 bits
Product: WebKit Reporter: Thierry Bastian <thierry.bastian>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Enhancement CC: benjamin, vanboxem.ruben, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
patch for adding 64 bit support to mingw webkit.review.bot: commit-queue-

Thierry Bastian
Reported 2010-02-25 01:28:07 PST
This was a request from Qt users to be able to build Qt (including webkit) with mingw 64 bits. It can be found here (http://sourceforge.net/projects/mingw-w64/files/Toolchains%20targetting%20Win64/Personal%20Builds/sezero_20100212/mingw-w64-bin_x86_64-mingw_20100212_sezero.zip/download). It is not yet released but we'd like to be one step ahead. The patch is pretty harmless and is mostly about avoiding casting pointers to int or long (which are 32 bits on mingw).
Attachments
patch for adding 64 bit support to mingw (7.38 KB, patch)
2010-02-25 01:30 PST, Thierry Bastian 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Thierry Bastian
Comment 1 2010-02-25 01:30:36 PST
Created attachment 49468 [details] patch for adding 64 bit support to mingw
Benjamin Poulain
Comment 2 2010-02-27 04:34:08 PST
Note that there is also the patch of https://bugs.webkit.org/show_bug.cgi?id=34922 to fix the build.
WebKit Review Bot
Comment 3 2010-02-27 04:38:34 PST
Attachment 49468 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/ChangeLog:4: Line contains tab character. [whitespace/tab] [5] JavaScriptCore/ChangeLog:4: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
vanboxem.ruben
Comment 4 2010-02-27 04:50:42 PST
See bug report https://bugs.webkit.org/show_bug.cgi?id=34922 for patch that passes all autochecks.
Thierry Bastian
Comment 5 2010-03-01 01:19:13 PST
Well if somebody else submitted a better patch, et's just close this one. *** This bug has been marked as a duplicate of bug 34922 ***
Benjamin Poulain
Comment 6 2010-03-03 00:38:42 PST
Comment on attachment 49468 [details] patch for adding 64 bit support to mingw Clear the review flags.
WebKit Review Bot
Comment 7 2011-05-05 19:58:58 PDT
Comment on attachment 49468 [details] patch for adding 64 bit support to mingw Attachment 92485 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8593073 New failing tests: plugins/audio-top-level-wav-load.html
Note You need to log in before you can comment on or make changes to this bug.