Bug 32815

Summary: Detailed boundingBoxes in SVG Renderer
Product: WebKit Reporter: Dirk Schulze <krit>
Component: SVGAssignee: Dirk Schulze <krit>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, paroga, webkit.review.bot, zimmermann
Priority: P2    
Version: 525.x (Safari 3.1)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 26231, 30055, 32584, 32935    
Attachments:
Description Flags
New bounding boxes for SVG
zimmermann: review+
Updated LayoutTest results for new SVG boundingBoxes zimmermann: review+

Dirk Schulze
Reported 2009-12-21 00:12:41 PST
We need more detailed boundingBoxes in the SVG Renderer. That would help to minimize ImageBuffer sizes for Maskers, Filters, Patterns and would correct repaintRectInLocalCoordinates(). repaintRectInLocalCoordinates() is not useable at the moment, because it gives back wrong drawing rects. Seperate boundingboxes of strokeRects, filterRects, maskRects, clipperRects, markerRects would be usefull.
Attachments
New bounding boxes for SVG (43.83 KB, patch)
2009-12-28 12:49 PST, Dirk Schulze 		zimmermann: review+
DetailsFormatted DiffDiff
Updated LayoutTest results for new SVG boundingBoxes (292.37 KB, patch)
2009-12-28 12:50 PST, Dirk Schulze 		zimmermann: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Schulze
Comment 1 2009-12-28 12:49:29 PST
Created attachment 45570 [details] New bounding boxes for SVG New boundingboxes for masker, clipper, filter, marker and stroke were added, repaintRectInLocalCoordinates was fixed.
Dirk Schulze
Comment 2 2009-12-28 12:50:41 PST
Created attachment 45571 [details] Updated LayoutTest results for new SVG boundingBoxes Updated test results after the changes on repaintRectInLocalCoordinates.
WebKit Review Bot
Comment 3 2009-12-28 12:55:21 PST
style-queue ran check-webkit-style on attachment 45570 [details] without any errors.
WebKit Review Bot
Comment 4 2009-12-28 12:56:06 PST
style-queue ran check-webkit-style on attachment 45571 [details] without any errors.
Nikolas Zimmermann
Comment 5 2009-12-29 02:53:39 PST
Comment on attachment 45570 [details] New bounding boxes for SVG We have iterated this patch several times, looks fine. r=me.
Eric Seidel (no email)
Comment 6 2009-12-29 20:50:55 PST
Attachment 45571 [details] was posted by a committer and has review+, assigning to Dirk Schulze for commit.
Dirk Schulze
Comment 7 2009-12-29 23:39:57 PST
*** Bug 33043 has been marked as a duplicate of this bug. ***
Dirk Schulze
Comment 8 2009-12-30 00:58:53 PST
landed patch in r52647 and a forgotten LayoutTest result in r52749. Closing bug now.
Note You need to log in before you can comment on or make changes to this bug.