Bug 32713

Summary: [Qt] make wtf/Assertions.h compile in winscw compiler.
Product: WebKit Reporter: Yongjun Zhang <yongjun.zhang>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hausmann, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: S60 Emulator   
OS: S60 3rd edition   
Bug Depends on:    
Bug Blocks: 27065    
Attachments:
Description Flags
adding arg string before ellipsis to fix the issue. none

Yongjun Zhang
Reported 2009-12-18 07:45:52 PST
In wtf/Assertion.h, for variadic macro like ASSERT_WITH_MESSAGE(assertion, ...), winscw compiler doesn't recognize ellipsis alone in the macro definition; adding string arg before ellipsis make it compile fine.
Attachments
adding arg string before ellipsis to fix the issue. (3.01 KB, patch)
2009-12-18 07:59 PST, Yongjun Zhang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yongjun Zhang
Comment 1 2009-12-18 07:59:14 PST
Created attachment 45151 [details] adding arg string before ellipsis to fix the issue.
WebKit Review Bot
Comment 2 2009-12-18 08:01:25 PST
style-queue ran check-webkit-style on attachment 45151 [details] without any errors.
Simon Hausmann
Comment 3 2009-12-18 08:23:07 PST
Comment on attachment 45151 [details] adding arg string before ellipsis to fix the issue. r=me
WebKit Commit Bot
Comment 4 2009-12-18 13:18:23 PST
Comment on attachment 45151 [details] adding arg string before ellipsis to fix the issue. Clearing flags on attachment: 45151 Committed r52337: <http://trac.webkit.org/changeset/52337>
WebKit Commit Bot
Comment 5 2009-12-18 13:18:27 PST
All reviewed patches have been landed. Closing bug.
Simon Hausmann
Comment 6 2009-12-30 01:19:05 PST
It turns out that this patch breaks the rvct release build: WebCore\loader\documentloader.cpp", line 793: Error: #135: class "WebCore::String" has no member "ascii" I'm investigating
Simon Hausmann
Comment 7 2009-12-30 01:47:37 PST
Sorry, false alarm. I merged this fix incorrectly (fixed now in c07df5686b431aa5d11643d00308d8f8f59d88b1 )
Note You need to log in before you can comment on or make changes to this bug.