Bug 32612

Summary: [GTK] Add WebKitEnableCaretBrowsing key to the layoutTestController.overridePreference call
Product: WebKit Reporter: Alejandro G. Castro <alex>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Proposed patch adding the API
none
Proposed patch
none
Proposed patch none

Alejandro G. Castro
Reported 2009-12-16 08:47:34 PST
We need this API in order to test the caret browsing from the DRT.
Attachments
Proposed patch adding the API (1.30 KB, patch)
2009-12-16 08:52 PST, Alejandro G. Castro 		no flags
DetailsFormatted DiffDiff
Proposed patch (5.82 KB, patch)
2009-12-16 08:54 PST, Alejandro G. Castro 		no flags
DetailsFormatted DiffDiff
Proposed patch (2.14 KB, patch)
2009-12-17 03:02 PST, Alejandro G. Castro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alejandro G. Castro
Comment 1 2009-12-16 08:52:49 PST
Created attachment 44981 [details] Proposed patch adding the API
Alejandro G. Castro
Comment 2 2009-12-16 08:54:37 PST
Created attachment 44982 [details] Proposed patch Upload the right patch.
WebKit Review Bot
Comment 3 2009-12-16 08:55:08 PST
Attachment 44982 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:565: Use 0 instead of NULL. [readability/null] [5] Total errors found: 1
Eric Seidel (no email)
Comment 4 2009-12-16 13:15:47 PST
I wonder if we shouldn't just enable/disable this via the layoutTestController.overridePreference call instead. We'd just have to come up with a name for this preference.
Alejandro G. Castro
Comment 5 2009-12-17 01:30:54 PST
(In reply to comment #4) > I wonder if we shouldn't just enable/disable this via the > layoutTestController.overridePreference call instead. We'd just have to come > up with a name for this preference. You are right, thanks for the comment.
Alejandro G. Castro
Comment 6 2009-12-17 01:39:05 PST
Resolved by mistake, we need the patch adding the property.
Alejandro G. Castro
Comment 7 2009-12-17 03:02:33 PST
Created attachment 45051 [details] Proposed patch Using the overridePreference API.
WebKit Review Bot
Comment 8 2009-12-17 03:06:13 PST
style-queue ran check-webkit-style on attachment 45051 [details] without any errors.
Eric Seidel (no email)
Comment 9 2009-12-17 12:59:39 PST
Comment on attachment 45051 [details] Proposed patch LGTM!
WebKit Commit Bot
Comment 10 2009-12-17 13:26:11 PST
Comment on attachment 45051 [details] Proposed patch Clearing flags on attachment: 45051 Committed r52284: <http://trac.webkit.org/changeset/52284>
WebKit Commit Bot
Comment 11 2009-12-17 13:26:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.