Bug 32429

Summary: Add capability for ChromeClient implementations to refer 'accept' attribute value of an INPUT element
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://www.whatwg.org/specs/web-apps/current-work/multipage/number-state.html#attr-input-accept
Bug Depends on:    
Bug Blocks: 19264, 32473    
Attachments:
Description Flags
Proposed patch none

Kent Tamura
Reported 2009-12-11 06:39:31 PST
ChromeClient::runOpenPanel() implementation should be able to refer 'accept' attribute to support it.
Attachments
Proposed patch (2.87 KB, patch)
2009-12-11 06:49 PST, Kent Tamura 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2009-12-11 06:49:22 PST
Created attachment 44685 [details] Proposed patch
WebKit Review Bot
Comment 2 2009-12-11 06:53:53 PST
style-queue ran check-webkit-style on attachment 44685 [details] without any errors.
Darin Fisher (:fishd, Google)
Comment 3 2009-12-11 09:25:35 PST
Comment on attachment 44685 [details] Proposed patch > +++ b/WebCore/rendering/RenderFileUploadControl.cpp ... > +String RenderFileUploadControl::acceptTypes() > +{ > + HTMLInputElement* input = static_cast<HTMLInputElement*>(node()); > + return input->accept(); > +} nit: no need for the input variable, just do: return static_cast<HTMLInputElement*>(node())->accept(); Otherwise, R=me
Kent Tamura
Comment 4 2009-12-11 10:16:35 PST
(In reply to comment #3) Thank you for reviewing. > nit: no need for the input variable, just do: > > return static_cast<HTMLInputElement*>(node())->accept(); > > Otherwise, R=me Fixed it, and commit manually as r52003.
Note You need to log in before you can comment on or make changes to this bug.