Bug 31158

Summary: [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
Product: WebKit Reporter: Antonio Gomes <tonikitoo>
Component: Tools / TestsAssignee: Antonio Gomes <tonikitoo>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Qt
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 30573    
Attachments:
Description Flags
(committed in r50621) patch none

Antonio Gomes
Reported 2009-11-05 02:25:50 PST
qt drt's WorkQueue has the now obsolete queueScript method. It is being called by no one now, and got replaced in mac DRT by queueNonLoadingScript and queueLoadingScript. $ vim LayoutTests/ChangeLog-2009-06-16 +8615 " * http/tests/navigation/fallback-anchor-reload.html: Removed use of queueScript here for a script that can instead just be run immedidately. * http/tests/navigation/resources/testcode.js: Use queueNonLoadingScript instead of queueScript for scripts that don't involve submitting a form. Use queueLoadingScript for scripts that do involve submitting a form. "
Attachments
(committed in r50621) patch (5.78 KB, patch)
2009-11-05 04:08 PST, Antonio Gomes 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antonio Gomes
Comment 1 2009-11-05 04:08:14 PST
Created attachment 42554 [details] (committed in r50621) patch make removed queueScript (no being used by any layout test) and add queueNonLoadingScript and queueLoadingScript.
Holger Freyther
Comment 2 2009-11-07 01:06:19 PST
Comment on attachment 42554 [details] (committed in r50621) patch Looks fine
Antonio Gomes
Comment 3 2009-11-08 09:28:05 PST
r50621
Note You need to log in before you can comment on or make changes to this bug.