Bug 30569

Summary: [Qt] webcore.pro incorrect linking of sqlite3 on Symbian
Product: WebKit Reporter: Janne Koskinen <koshuin>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Critical CC: commit-queue, laszlo.gombos
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: S60 Hardware   
OS: S60 3rd edition   
Bug Depends on:    
Bug Blocks: 27065    
Attachments:
Description Flags
proposed fix for webcore.pro none

Janne Koskinen
Reported 2009-10-20 06:41:58 PDT
Sqlite3 should be dynamically linked in Symbian as the sqlite3.dll is now provided by the system or as an additional installed library depending on platform/target device version. webcore.pro will try make the linker to try link it statically due to ".lib" in LIBS statement and in Symbian environment will cause sqlite3.lib to be searched from wrong path causing build break if the file is not manually copied to that directory. With copying you end up with static linking.
Attachments
proposed fix for webcore.pro (1.09 KB, patch)
2009-10-20 06:46 PDT, Janne Koskinen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Janne Koskinen
Comment 1 2009-10-20 06:46:17 PDT
Created attachment 41504 [details] proposed fix for webcore.pro
Eric Seidel (no email)
Comment 2 2009-10-21 10:39:02 PDT
Comment on attachment 41504 [details] proposed fix for webcore.pro This looks fine to me. Seems a qt person would be a better reviewer though.
Tor Arne Vestbø
Comment 3 2009-10-23 06:36:37 PDT
Comment on attachment 41504 [details] proposed fix for webcore.pro LGTM
WebKit Commit Bot
Comment 4 2009-10-23 06:44:12 PDT
Comment on attachment 41504 [details] proposed fix for webcore.pro Rejecting patch 41504 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11506 test cases. fast/media/mq-transform-02.html -> failed Exiting early after 1 failures. 7441 tests run. 139.03s total testing time 7440 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 3 test cases (<1%) had stderr output
Eric Seidel (no email)
Comment 5 2009-10-23 12:01:48 PDT
Comment on attachment 41504 [details] proposed fix for webcore.pro Sorry about the commit-queue trouble. Should work fine now.
WebKit Commit Bot
Comment 6 2009-10-23 12:14:35 PDT
Comment on attachment 41504 [details] proposed fix for webcore.pro Clearing flags on attachment: 41504 Committed r49986: <http://trac.webkit.org/changeset/49986>
WebKit Commit Bot
Comment 7 2009-10-23 12:14:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.