Bug 29725

Summary: Add ARM version detection rules for Symbian
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: laszlo.gombos, loki
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Other   
Attachments:
Description Flags
proposed patch none

Laszlo Gombos
Reported 2009-09-24 15:28:20 PDT
Platform.h has a set of rules to detect ARM HW version. The detection rules seems to be specific (to GCC) and does not work for Symbian. A patch will follow to add the appropriate Symbian defines to detect ARM HW version using the Symbian toolchain. Without this change the Symbian build would fail since the compiler would hit #error "Not supported ARM architecture", which was recently added (see http://trac.webkit.org/changeset/48525)
Attachments
proposed patch (1.56 KB, patch)
2009-09-24 15:36 PDT, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2009-09-24 15:36:46 PDT
Created attachment 40086 [details] proposed patch
Laszlo Gombos
Comment 2 2009-09-24 15:40:08 PDT
Comment on attachment 40086 [details] proposed patch cancel the review as this is a dup of bug 29715; will upload this patch there for review.
Laszlo Gombos
Comment 3 2009-09-24 15:44:49 PDT
*** This bug has been marked as a duplicate of bug 29715 ***
Note You need to log in before you can comment on or make changes to this bug.