Bug 29623

Summary: Media test files in Ogg and Theora formats
Product: WebKit Reporter: Hin-Chung Lam <hclam>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Test files for ogg and theora, transcoded from originals
none
Test files for ogg and theora, transcoded from originals
none
Test files for ogg and theora, transcoded from originals none

Hin-Chung Lam
Reported 2009-09-21 17:39:42 PDT
Provide Ogg and Theora formatted test files.
Attachments
Test files for ogg and theora, transcoded from originals (431.86 KB, patch)
2009-09-21 17:43 PDT, Hin-Chung Lam 		no flags
DetailsFormatted DiffDiff
Test files for ogg and theora, transcoded from originals (431.86 KB, patch)
2009-09-21 17:44 PDT, Hin-Chung Lam 		no flags
DetailsFormatted DiffDiff
Test files for ogg and theora, transcoded from originals (431.86 KB, patch)
2009-09-21 17:44 PDT, Hin-Chung Lam 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Hin-Chung Lam
Comment 1 2009-09-21 17:43:35 PDT
Created attachment 39896 [details] Test files for ogg and theora, transcoded from originals
Hin-Chung Lam
Comment 2 2009-09-21 17:44:23 PDT
Created attachment 39897 [details] Test files for ogg and theora, transcoded from originals
Hin-Chung Lam
Comment 3 2009-09-21 17:44:49 PDT
Created attachment 39898 [details] Test files for ogg and theora, transcoded from originals
Eric Seidel (no email)
Comment 4 2009-09-22 14:37:46 PDT
Seems fine to me, although Eric would be the best person to rubber stamp this.
Eric Carlson
Comment 5 2009-09-22 14:47:41 PDT
Comment on attachment 39898 [details] Test files for ogg and theora, transcoded from originals r(ubberstamp) = me
WebKit Commit Bot
Comment 6 2009-09-22 15:25:36 PDT
Comment on attachment 39898 [details] Test files for ogg and theora, transcoded from originals Rejecting patch 39898 from commit-queue. Patch https://bugs.webkit.org/attachment.cgi?id=39898 from bug 29623 failed to download and apply.
Eric Seidel (no email)
Comment 7 2009-09-22 15:28:17 PDT
patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patch: **** Only garbage was found in the patch input. patching file LayoutTests/media/content/garbage.ogv error: pathspec 'LayoutTests/media/content/counting.ogv' did not match any file(s) known to git. Did you forget to 'git add'? error: pathspec 'LayoutTests/media/content/silence.oga' did not match any file(s) known to git. Did you forget to 'git add'? error: pathspec 'LayoutTests/media/content/test.oga' did not match any file(s) known to git. Did you forget to 'git add'? error: pathspec 'LayoutTests/media/content/test.ogv' did not match any file(s) known to git. Did you forget to 'git add'? I think this is known trouble with svn-apply and git patches. I'm not sure though.
Eric Seidel (no email)
Comment 8 2009-09-22 15:29:15 PDT
This looks like the same failures as bug 29100, but I just fixed that, so I'm not sure. Maybe I didn't fix it right.
Hin-Chung Lam
Comment 9 2009-09-22 15:31:29 PDT
I generate the patch using svn-create-patch but not git, would this be the reason?
Eric Carlson
Comment 10 2009-09-22 21:57:53 PDT
The problem was with the entry for empty.oga: Index: LayoutTests/media/content/empty.oga =================================================================== patch apparently can't handle a completely empty file. I removed that line from the patch, applied it locally, created the empty.oga manually, and added it to svn and all was fine. http://trac.webkit.org/changeset/48667
Eric Seidel (no email)
Comment 11 2009-09-22 23:01:15 PDT
(In reply to comment #10) > The problem was with the entry for empty.oga: > > Index: LayoutTests/media/content/empty.oga > =================================================================== > > patch apparently can't handle a completely empty file. I removed that line from > the patch, applied it locally, created the empty.oga manually, and added it to > svn and all was fine. > > http://trac.webkit.org/changeset/48667 Seems like we'll need to file a bug about that. svn-apply should be able to handle such.
Eric Carlson
Comment 12 2009-09-23 08:12:50 PDT
Filed https://bugs.webkit.org/show_bug.cgi?id=29684
Hin-Chung Lam
Comment 13 2009-09-23 10:55:51 PDT
Thanks for the review and landing this for me!
Note You need to log in before you can comment on or make changes to this bug.