Bug 29509
| Summary: | svn-create-patch or check-webkit-style should warn about tabs | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | abarth, ddkilzer, levin |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
Eric Seidel (no email)
svn-create-patch or check-webkit-style should warn about tabs
Right now we only find out about tabs in files/ChangeLogs until commit time. This means reviewers have to manually reject patches due to tabs, or the commit-queue ends up rejecting them later. We need a tighter feedback loop for contributers. This is a common problem for new contributers.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Eric Seidel (no email)
This is extra annoying now that we have the style-queue which should be catching this type of thing:
https://bugs.webkit.org/show_bug.cgi?id=32100#c5
Eric Seidel (no email)
*** Bug 32039 has been marked as a duplicate of this bug. ***
David Levin
Resolving as a dup of a later bug since that other bug has the patch with a fix for svn-create-patch or check-webkit-style should warn about tabs and that seems like a good place for this.
*** This bug has been marked as a duplicate of bug 32538 ***