Bug 29507

Summary: Add MarkStackSymbian.cpp to build JavascriptCore for Symbian.
Product: WebKit Reporter: Yongjun Zhang <yongjun.zhang>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, koshuin, laszlo.gombos
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: S60 Hardware   
OS: S60 3rd edition   
Bug Depends on:    
Bug Blocks: 27065    
Attachments:
Description Flags
add MarkStackSymbian.cpp and reuse windows port's shrinkAllocation().
eric: review-
Modified patch as per Eric's comments. hausmann: review+

Yongjun Zhang
Reported 2009-09-18 14:40:31 PDT
MarkStack has platform specific implementations for windows and posix based port. Symbian port needs to have Symbian specific MarkStack implementation to get JavaScriptCore compile.
Attachments
add MarkStackSymbian.cpp and reuse windows port's shrinkAllocation(). (4.75 KB, patch)
2009-09-18 14:48 PDT, Yongjun Zhang 		eric: review-
DetailsFormatted DiffDiff
Modified patch as per Eric's comments. (4.08 KB, patch)
2009-09-23 08:00 PDT, Yongjun Zhang 		hausmann: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yongjun Zhang
Comment 1 2009-09-18 14:48:47 PDT
Created attachment 39788 [details] add MarkStackSymbian.cpp and reuse windows port's shrinkAllocation(). Re-use Windows shrinkAllocation implementation because Symbian doesn't support releasing part of memory region. Use fastMalloc and fastFree to implement allocateStack and releaseStack for Symbian port.
Eric Seidel (no email)
Comment 2 2009-09-21 13:16:00 PDT
Comment on attachment 39788 [details] add MarkStackSymbian.cpp and reuse windows port's shrinkAllocation(). Seems like a lot of headers to include for such a simple .cpp file. I don't know if fastMalloc/fastFree will behave as you want them to or not. But I'm happy to r+ a patch with them in it as, you'll figure out very quickly if they're broken. ;) releaseStack ignores the "size" argument. Most of WebCore builds with -Wunused enabled, if symbian ever turns that warning back on, this will break. I'm not sure why Apple's copyright is copied into this tiny file. I think normally we have an extra line after the corresponding header include, in this case, I would expect a new line after +#include "MarkStack.h" r- for the above mentioned nits.
Yongjun Zhang
Comment 3 2009-09-23 08:00:08 PDT
Created attachment 39996 [details] Modified patch as per Eric's comments. thanks for the comments, Eric. In the modified patch, I copied the copyright notice from files in Qt port to keep it consistent.
Eric Seidel (no email)
Comment 4 2009-09-23 17:25:58 PDT
Comment on attachment 39996 [details] Modified patch as per Eric's comments. What is this supposed to mean? 2 Copyright (C) 2009 Nokia Corporation and/or its subsidiary(-ies) I've never seen such a copyright line. If you're intending to assign copyright to a specific entity, please list that entity.
Janne Koskinen
Comment 5 2009-09-25 03:23:34 PDT
> I've never seen such a copyright line. If you're intending to assign copyright > to a specific entity, please list that entity. Then you haven't been paying attention to what is going on in the trunk ;) That copyright is all over the place in webkit code.
Yongjun Zhang
Comment 6 2009-09-25 08:42:58 PDT
Comment on attachment 39996 [details] Modified patch as per Eric's comments. Hi Eric, I agree the copyright line looks a bit uncommon. It was however drafted by Nokia/Trolltech legal and is currently used in all Qt port files under WebKit/Qt. thanks.
Simon Hausmann
Comment 7 2009-09-26 05:44:51 PDT
Comment on attachment 39996 [details] Modified patch as per Eric's comments. r=me
Simon Hausmann
Comment 8 2009-09-26 05:47:41 PDT
Committed r48788: <http://trac.webkit.org/changeset/48788>
Note You need to log in before you can comment on or make changes to this bug.