Bug 28981

Summary: [Qt] make npapi.h compile in winscw compiler.
Product: WebKit Reporter: Yongjun Zhang <yongjun.zhang>
Component: Plug-insAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor CC: eric, laszlo.gombos
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: S60 Emulator   
OS: S60 3rd edition   
Bug Depends on:    
Bug Blocks: 27065    
Attachments:
Description Flags
Add XP_SYMBIAN macro for symbian build, and undef XP_WIN when building for Symbian. none

Yongjun Zhang
Reported 2009-09-04 12:18:06 PDT
Winscw compiler by default defines _WIN32 macro; in npapi.h, this macro assumes the target environment is Windows and it tries to include <windows.h> and other windows specific code into Symbian build, the compilation as a result fails.
Attachments
Add XP_SYMBIAN macro for symbian build, and undef XP_WIN when building for Symbian. (1.20 KB, patch)
2009-09-04 12:25 PDT, Yongjun Zhang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yongjun Zhang
Comment 1 2009-09-04 12:25:33 PDT
Created attachment 39084 [details] Add XP_SYMBIAN macro for symbian build, and undef XP_WIN when building for Symbian.
Eric Seidel (no email)
Comment 2 2009-09-08 11:12:57 PDT
Comment on attachment 39084 [details] Add XP_SYMBIAN macro for symbian build, and undef XP_WIN when building for Symbian. Rejecting patch 39084 from commit-queue. This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1
Eric Seidel (no email)
Comment 3 2009-09-08 12:11:07 PDT
Comment on attachment 39084 [details] Add XP_SYMBIAN macro for symbian build, and undef XP_WIN when building for Symbian. media/video-source-error.html -> timed out Yet another flakey media test. :( bug 28624
Eric Seidel (no email)
Comment 4 2009-09-08 12:21:21 PDT
Comment on attachment 39084 [details] Add XP_SYMBIAN macro for symbian build, and undef XP_WIN when building for Symbian. Clearing flags on attachment: 39084 Committed r48174: <http://trac.webkit.org/changeset/48174>
Eric Seidel (no email)
Comment 5 2009-09-08 12:21:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.