Bug 28830

Summary: [Gtk] DRT needs implementation of overridePreference
Product: WebKit Reporter: Jan Alonzo <jmalonzo>
Component: WebKitGTKAssignee: Jan Alonzo <jmalonzo>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Gtk
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 28823    
Attachments:
Description Flags
Patch v1 eric: review+, eric: commit-queue-

Jan Alonzo
Reported 2009-08-29 19:11:48 PDT
Some tests use this already so it would be nice if we can pass those tests too.
Attachments
Patch v1 (7.91 KB, patch)
2009-08-29 19:26 PDT, Jan Alonzo 		eric: review+
eric: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jan Alonzo
Comment 1 2009-08-29 19:26:01 PDT
Created attachment 38780 [details] Patch v1
Eric Seidel (no email)
Comment 2 2009-08-31 03:13:56 PDT
Comment on attachment 38780 [details] Patch v1 Looks great! I would have named "toWebSettingKey" "copyAsWebSettingKey" or something. To inform the caller that they need to release the returned string. It's so sad that we don't have some sort of GOwnPtr for DRT to use here instead of needing to manually g_free. Spacing: + if ( !(ss >> val).fail()) + static gboolean isInitialized = false; is not really needed, you can check !keyTable. Please adjust a little before landing.
Jan Alonzo
Comment 3 2009-09-01 05:06:52 PDT
(In reply to comment #2) > (From update of attachment 38780 [details]) > Looks great! > > I would have named "toWebSettingKey" "copyAsWebSettingKey" or something. To > inform the caller that they need to release the returned string. > > It's so sad that we don't have some sort of GOwnPtr for DRT to use here instead > of needing to manually g_free. > > Spacing: > + if ( !(ss >> val).fail()) > > + static gboolean isInitialized = false; > is not really needed, you can check !keyTable. > > Please adjust a little before landing. Adjusted. Thanks. Landed as http://trac.webkit.org/changeset/47928.
Note You need to log in before you can comment on or make changes to this bug.