Bug 28785

Summary: ImageDecoderFoo.cpp contains lots of copy & pasted code and should be refactored
Product: WebKit Reporter: Peter Kasting <pkasting>
Component: ImagesAssignee: Peter Kasting <pkasting>
Status: RESOLVED FIXED    
Severity: Normal CC: yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 26467    
Attachments:
Description Flags
Prep work before moving functions into ImageDecoder.cpp
none
Refactor eric: review+

Peter Kasting
Reported 2009-08-27 14:24:10 PDT
Similar to bug 27965. Skia and Qt are the odd platforms out; for now the others should use common implementations of this stuff.
Attachments
Prep work before moving functions into ImageDecoder.cpp (7.97 KB, patch)
2009-08-27 14:27 PDT, Peter Kasting 		no flags
DetailsFormatted DiffDiff
Refactor (10.29 KB, patch)
2009-08-27 16:35 PDT, Peter Kasting 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Peter Kasting
Comment 1 2009-08-27 14:27:32 PDT
Created attachment 38687 [details] Prep work before moving functions into ImageDecoder.cpp
Eric Seidel (no email)
Comment 2 2009-08-27 14:32:48 PDT
Comment on attachment 38687 [details] Prep work before moving functions into ImageDecoder.cpp LGTM.
Peter Kasting
Comment 3 2009-08-27 14:38:49 PDT
Comment on attachment 38687 [details] Prep work before moving functions into ImageDecoder.cpp Landed in r47836, clearing flags.
Peter Kasting
Comment 4 2009-08-27 16:35:58 PDT
Created attachment 38696 [details] Refactor Yay for removing duplicate copies of code.
Eric Seidel (no email)
Comment 5 2009-08-27 18:04:59 PDT
Comment on attachment 38696 [details] Refactor Why wouldn't we just move this into an RGBABuffer.cpp? This is definitely better than before, but we generally try to do one-class per file.
Peter Kasting
Comment 6 2009-08-28 10:37:52 PDT
(In reply to comment #5) > (From update of attachment 38696 [details]) > Why wouldn't we just move this into an RGBABuffer.cpp? This is definitely > better than before, but we generally try to do one-class per file. Yes, my eventual plan is to move this into a different file, in a different folder, with a different name.
Peter Kasting
Comment 7 2009-08-28 11:00:55 PDT
Fixed in r47867.
Note You need to log in before you can comment on or make changes to this bug.