Bug 28625

Summary: [REGRESSION] Focus ring problems in contentEditable areas
Product: WebKit Reporter: Peter Kasting <pkasting>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Critical CC: dglazkov, mitz
Priority: P2 Keywords: Regression
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on:    
Bug Blocks: 20329    
Attachments:
Description Flags
Patch to clamp to lineTop/lineBottom for all outline rects from line boxes. simon.fraser: review+

Peter Kasting
Reported 2009-08-21 14:44:50 PDT
Filing on behalf of dglazkov, originally noted on bug 20329 comment 18. "Landing [r47440 to fix bug 20329] introduced a pretty ghastly regression: The focus ring now snakes around overflowing objects in contenteditable areas. Take a look at this for instance on a ToT: http://trac.webkit.org/export/47638/trunk/LayoutTests/editing/pasteboard/styled-element-markup.html Part of the reason this wasn't caught because we don't run pixel tests on build bots."
Attachments
Patch to clamp to lineTop/lineBottom for all outline rects from line boxes. (3.69 KB, patch)
2009-08-21 15:16 PDT, Dave Hyatt 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2009-08-21 15:03:14 PDT
Consequence of letting boxes have their full height even in quirks mode. All focus ring rects that are added need to clamp themselves to the root line box top and line box bottom.
Dave Hyatt
Comment 2 2009-08-21 15:04:19 PDT
This is a quirks-mode-only bug basically.
Dave Hyatt
Comment 3 2009-08-21 15:14:26 PDT
"pretty ghastly regression" is a bit of an exaggeration by the way, given that contenteditable areas with overflow:visible set are pretty rare (as having an outline grow as you type is pretty bad UI to start with), and that the regression doesn't occur in strict mode either. :)
Dave Hyatt
Comment 4 2009-08-21 15:16:48 PDT
Created attachment 38405 [details] Patch to clamp to lineTop/lineBottom for all outline rects from line boxes.
Dave Hyatt
Comment 5 2009-08-21 15:20:09 PDT
Fixed in r47643.
Note You need to log in before you can comment on or make changes to this bug.