Bug 28273

Summary: [QT] revert the temporary S60 RVCT elftran workaround in qwebview.h when the right symbol is exported from Qt lib.
Product: WebKit Reporter: Yongjun Zhang <yongjun.zhang>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor CC: commit-queue, hausmann, koshuin, laszlo.gombos, norbert.leser, webkit.review.bot
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: S60 Hardware   
OS: S60 3rd edition   
Bug Depends on:    
Bug Blocks: 27065    
Attachments:
Description Flags
Patch none

Yongjun Zhang
Reported 2009-08-13 12:23:08 PDT
A temporary fix is introduced in https://bugs.webkit.org/show_bug.cgi?id=28181; it should be reverted when the right symbol is exported.
Attachments
Patch (1.54 KB, patch)
2009-12-12 16:19 PST, Simon Hausmann 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2009-11-11 18:26:31 PST
Is this fix in Qt 4.6 now ? Is it time to revert ?
Simon Hausmann
Comment 2 2009-11-29 15:59:57 PST
(In reply to comment #1) > Is this fix in Qt 4.6 now ? Is it time to revert ? Yes, it's fixed in Qt 4.6 and the fix is part of Qt 4.6.0: http://qt.gitorious.org/qt/qt/commit/8d0b487437e731ff3f5f97779002a4ffb48d92ec Unfortunately we missed this revert in WebKit for 4.6.0, but we should still do it in the trunk of course :)
Simon Hausmann
Comment 3 2009-12-12 16:19:37 PST
Created attachment 44746 [details] Patch
WebKit Review Bot
Comment 4 2009-12-12 16:22:50 PST
style-queue ran check-webkit-style on attachment 44746 [details] without any errors.
WebKit Commit Bot
Comment 5 2009-12-13 01:31:49 PST
Comment on attachment 44746 [details] Patch Clearing flags on attachment: 44746 Committed r52065: <http://trac.webkit.org/changeset/52065>
WebKit Commit Bot
Comment 6 2009-12-13 01:31:54 PST
All reviewed patches have been landed. Closing bug.
Simon Hausmann
Comment 7 2009-12-14 02:00:28 PST
I was talking rubbish: Of course we can include this in 4.6.x, as it doesn not affect the number of exported symbols at all. Cherry-picked as commit 488a95f395a49bdd781d878891b45c61b450404a
Note You need to log in before you can comment on or make changes to this bug.