Bug 28181

Summary: RVCT elftran fails to resolve QPainter::staticMetaObject coming with QWebView::RenderHints property.
Product: WebKit Reporter: Yongjun Zhang <yongjun.zhang>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, hausmann, laszlo.gombos
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: S60 Emulator   
OS: S60 3rd edition   
Bug Depends on:    
Bug Blocks: 27065    
Attachments:
Description Flags
don't use RenderHint property when building for symbian.
eric: review-
Modified patch as per Eric's comments.
eric: review-
Remove tab in previous patch (bad copy&paste habbit :) ) hausmann: review+

Yongjun Zhang
Reported 2009-08-11 10:41:21 PDT
QWebView::RenderHints property makes QWebView::staticMetaObject depends on QPainter::staticMetaObject with breaks RVCT elftran linking. We have to remove this property now, until the right symbol is exported.
Attachments
don't use RenderHint property when building for symbian. (1.45 KB, patch)
2009-08-11 11:30 PDT, Yongjun Zhang 		eric: review-
DetailsFormatted DiffDiff
Modified patch as per Eric's comments. (1.67 KB, patch)
2009-08-13 12:31 PDT, Yongjun Zhang 		eric: review-
DetailsFormatted DiffDiff
Remove tab in previous patch (bad copy&paste habbit :) ) (1.69 KB, patch)
2009-08-13 12:50 PDT, Yongjun Zhang 		hausmann: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yongjun Zhang
Comment 1 2009-08-11 11:30:16 PDT
Created attachment 34579 [details] don't use RenderHint property when building for symbian. It is a temporary fix, should be reverted when the right symbol is exported from QT lib.
Eric Seidel (no email)
Comment 2 2009-08-11 22:34:14 PDT
Comment on attachment 34579 [details] don't use RenderHint property when building for symbian. The code you're adding should have a FIXME explaining the temporary nature.
Eric Seidel (no email)
Comment 3 2009-08-11 22:34:35 PDT
You also should file a bug about backing this out (and ideally link to it from your FIXME)
Yongjun Zhang
Comment 4 2009-08-13 12:31:23 PDT
Created attachment 34771 [details] Modified patch as per Eric's comments. Thanks for the quick review. I modified the patch as suggested in the comments: 1. created a bug (https://bugs.webkit.org/show_bug.cgi?id=28273) to remind me to revert the change later. 2. added //FIXME comment and link to the above bug.
Eric Seidel (no email)
Comment 5 2009-08-13 12:40:04 PDT
Comment on attachment 34771 [details] Modified patch as per Eric's comments. Tab in ChangeLog. r- as that will fail to land. So is there a bug with upstream Qt about getting this resolved? OR does nokia build some custom S60 Qt, and thus the bug would be with Nokia?
Yongjun Zhang
Comment 6 2009-08-13 12:50:30 PDT
Created attachment 34773 [details] Remove tab in previous patch (bad copy&paste habbit :) ) This bug will be fixed in upstream Qt for S60. This is a temporary fix to make webkit build with current Qt 4.5.2 for S60.
Eric Seidel (no email)
Comment 7 2009-08-13 13:13:14 PDT
Do we have a bug number for the upstream fix?
Simon Hausmann
Comment 8 2009-08-13 13:52:00 PDT
Good point Eric, there is a bug number. I'll dig it out tomorrow.
Eric Seidel (no email)
Comment 9 2009-08-13 13:53:12 PDT
Thank you. I just figure it's best that we get all the documentation in the right place now, while we're making the change, instead of 3 years from now, when we're wondering if we can back it out or not. ;)
Simon Hausmann
Comment 10 2009-08-14 01:34:30 PDT
The upstream bug report in Qt is tracked at http://qt.nokia.com/developer/task-tracker/index_html?method=entry&id=258893
Simon Hausmann
Comment 11 2009-08-14 07:48:41 PDT
Comment on attachment 34773 [details] Remove tab in previous patch (bad copy&paste habbit :) ) r=me I'll change the url in the comment to the upstream bug url when landing.
Simon Hausmann
Comment 12 2009-08-14 07:50:33 PDT
Landed in r47285
Note You need to log in before you can comment on or make changes to this bug.