Bug 28008

Summary: fast/forms/textfield-drag-into-disabled.html has a needless 5 second delay
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 27995    
Attachments:
Description Flags
Patch v1 simon.fraser: review+

Eric Seidel (no email)
Reported 2009-08-04 18:14:36 PDT
fast/forms/textfield-drag-into-disabled.html has a needless 5 second delay This layout test is from another era. I've updated it to be dumpAsText and not need a 5-second delay to test dragging. I validated that I didn't break the test by temporarily removing the "disabled" flag from the <input> and checking that the drag succeeded (i.e. the test failed) with disabled removed.
Attachments
Patch v1 (11.71 KB, patch)
2009-08-04 18:16 PDT, Eric Seidel (no email) 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2009-08-04 18:16:27 PDT
Created attachment 34106 [details] Patch v1
Eric Seidel (no email)
Comment 2 2009-08-04 18:34:49 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... D LayoutTests/platform/mac/fast/forms/textfield-drag-into-disabled-expected.checksum D LayoutTests/platform/mac/fast/forms/textfield-drag-into-disabled-expected.png D LayoutTests/platform/mac/fast/forms/textfield-drag-into-disabled-expected.txt D LayoutTests/platform/qt/fast/forms/textfield-drag-into-disabled-expected.txt D LayoutTests/platform/win/fast/forms/textfield-drag-into-disabled-expected.txt M LayoutTests/ChangeLog A LayoutTests/fast/forms/textfield-drag-into-disabled-expected.txt M LayoutTests/fast/forms/textfield-drag-into-disabled.html Committed r46790 D LayoutTests/platform/mac/fast/forms/textfield-drag-into-disabled-expected.txt D LayoutTests/platform/mac/fast/forms/textfield-drag-into-disabled-expected.png D LayoutTests/platform/mac/fast/forms/textfield-drag-into-disabled-expected.checksum D LayoutTests/platform/qt/fast/forms/textfield-drag-into-disabled-expected.txt D LayoutTests/platform/win/fast/forms/textfield-drag-into-disabled-expected.txt M LayoutTests/ChangeLog A LayoutTests/fast/forms/textfield-drag-into-disabled-expected.txt M LayoutTests/fast/forms/textfield-drag-into-disabled.html r46790 = 0e2037c9047382a8aee9bdbd132f550c58725acd (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46790
Mark Rowe (bdash)
Comment 3 2009-08-05 00:32:10 PDT
Another good example of why bug 26920 should be addressed.
Note You need to log in before you can comment on or make changes to this bug.