Bug 27064

Summary: Turn off non-portable date manipulations for SYMBIAN (as well)
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer, hausmann, norbert.leser, yongjun.zhang
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on:    
Bug Blocks: 27065    
Attachments:
Description Flags
Proposed fix. ddkilzer: review+

Laszlo Gombos
Reported 2009-07-07 20:17:17 PDT
The timegm() function and the tm_gmtoff and tm_zone fields are extensions to the ISO and POSIX standards; these are not available on WIN and some other UNIX-like systems (SOLARIS, SYMBIAN). The rules to turn off these non-portable dependencies are repeated several times in wtf/DateMath.*. Perhaps we should introduce HAVE_XXX guards for these non-portable dependencies and place the rules in one single location.
Attachments
Proposed fix. (3.56 KB, patch)
2009-07-07 20:31 PDT, Laszlo Gombos 		ddkilzer: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2009-07-07 20:31:25 PDT
Created attachment 32425 [details] Proposed fix.
David Kilzer (:ddkilzer)
Comment 2 2009-07-14 09:21:56 PDT
Comment on attachment 32425 [details] Proposed fix. Nice. r=me
Simon Hausmann
Comment 3 2009-07-15 07:18:49 PDT
Nice, landed in r45908
Note You need to log in before you can comment on or make changes to this bug.