Bug 26915

> We have a ... We should have a ...

Hi Kent, (In reply to comment #0) > We should have a HTMLDataListElement DOM object for a <datalist> element. I don't know what your implementation plans/schedule are with regard to the <output> element, but just wanted to know you might also want to make a reminder about the adding an HTMLOutputElement IDL (if you haven't already).

(In reply to comment #2) > ... but just wanted to know you might also want to" make that, "but just wanted to say you might also want to"

Mike, <output> element support will be another bug.

Created attachment 32290 [details] Proposed patch

Comment on attachment 32290 [details] Proposed patch The whitespace style updates make this hard to read.

Created attachment 32363 [details] Proposed patch (rev.2) Reverted the whitespace changes in HTMLCollection.cpp

Created attachment 32645 [details] Proposed patch (rev.3) Updates more build files including .gypi

Comment on attachment 32645 [details] Proposed patch (rev.3) Your ChangeLog is doubled. Why is this right? bool HTMLDataListElement::checkDTD(const Node* newChild) 48 { 49 return newChild->hasTagName(HTMLNames::optionTag) || HTMLElement::checkDTD(newChild); 50 } You should add a test to test the checkDTD code. If you're trying to prevent adding non-option elements then we need to test that? Otherwise this looks fine. r- since you're not a committer and this needs a small update (and ideally another test).

(In reply to comment #9) > (From update of attachment 32645 [details]) > Your ChangeLog is doubled. Fixed. > Why is this right? > bool HTMLDataListElement::checkDTD(const Node* newChild) > 48 { > 49 return newChild->hasTagName(HTMLNames::optionTag) || > HTMLElement::checkDTD(newChild); > 50 } According to the standard, we need to allow <options>s and inline elements. So HTMLElement::checkDTD() was wrong. I have changed it to inInlineTagList(), and added a test for this behavior.

Created attachment 32835 [details] Proposed patch (rev.4) - Updated ChangeLog - Changed checkDTD() - Added another test

Created attachment 33409 [details] Proposed patch (rev.5) Just updated the patch for project.pbxproj because the previous patch made a conflict with the current source.

dhyatt was working on <datalist> support, he should be CCed on all bugs about it

Comment on attachment 33409 [details] Proposed patch (rev.5) As an unfinished feature, it seems this should be guarded by some sort of ENABLE_

Created attachment 34441 [details] Proposed patch (rev.6) Intoruduces ENABLE_DATALIST.

Comment on attachment 34441 [details] Proposed patch (rev.6) OK.

Comment on attachment 34441 [details] Proposed patch (rev.6) Rejecting patch 34441 from commit-queue. This patch will require manual commit. Patch https://bugs.webkit.org/attachment.cgi?id=34441 from bug 26915 failed to download and apply.

patching file WebCore/Configurations/FeatureDefines.xcconfig Hunk #1 succeeded at 37 with fuzz 2. Hunk #2 FAILED at 60. 1 out of 2 hunks FAILED -- saving rejects to file WebCore/Configurations/FeatureDefines.xcconfig.rej

Created attachment 35017 [details] Proposed patch (rev.7) Patch for today's WebKit.

Comment on attachment 35017 [details] Proposed patch (rev.7) LGTM.

Comment on attachment 35017 [details] Proposed patch (rev.7) Clearing flags on attachment: 35017 Committed r47420: <http://trac.webkit.org/changeset/47420>

All reviewed patches have been landed. Closing bug.