Bug 255035
| Summary: | [ews] A PR that failed to fix a pre-existing test failure was marked as green even though the test was still failing | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | aakash_jain, ap, jbedard, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryan Haddad
Here is an interesting case with our EWS + results DB integration, but I’m not sure how we’d mitigate it:
https://github.com/WebKit/WebKit/pull/11769 was supposed to fix TestWebKitAPI.WebKit.MediaBufferingPolicy, and since EWS was ignoring the failure based on post-commit results, it ignored the fact that the test continued to fail with the PR and marked the run as ✅ https://ews-build.webkit.org/#/builders/18/builds/1253
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/107662421>
Ryan Haddad
*** Bug 258005 has been marked as a duplicate of this bug. ***