Bug 252922
Summary: | REGRESSION (260447@main): [Monterey+] TestWebKitAPI.FontManagerTests.ChangeFontWithPanel is consistently failing | ||
---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> |
Component: | CSS | Assignee: | Wenson Hsieh <wenson_hsieh> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | gfunni234, mmaxfield, webkit-bot-watchers-bugzilla, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=247987 |
Ryan Haddad
TestWebKitAPI.FontManagerTests.ChangeFontWithPanel has been consistently failing on macOS after https://commits.webkit.org/260447@main landed. The test is passing on Big Sur, but failing on Monterey and Ventura.
TestWebKitAPI.FontManagerTests.ChangeFontWithPanel
2023-02-17 09:16:43.579 TestWebKitAPI[1400:24471392] Expected "Helvetica 20.00 pt. P [] (0x7fd520527290) fobj=0x7fd520168410, spc=5.56" to have the same attributes as "Helvetica 20.00 pt. P [] (0x7fd4d7732090) fobj=0x7fd4d7732090, spc=5.56"
2023-02-17 09:16:43.648 TestWebKitAPI[1400:24471392] Expected "TimesNewRomanPS-BoldMT 10.00 pt. P [] (0x7fd520527290) fobj=0x7fd520527290, spc=2.50" to have the same attributes as "TimesNewRomanPS-BoldMT 10.00 pt. P [] (0x7fd4d775e7b0) fobj=0x7fd4d775e7b0, spc=2.50"
2023-02-17 09:16:43.713 TestWebKitAPI[1400:24471392] Expected "Arial-BoldItalicMT 14.00 pt. P [] (0x7fd517705190) fobj=0x7fd520338540, spc=3.89" to have the same attributes as "Arial-BoldItalicMT 14.00 pt. P [] (0x7fd51770eea0) fobj=0x7fd51770eea0, spc=3.89"
/Volumes/Data/worker/Apple-Ventura-Release-Build/build/Tools/TestWebKitAPI/Tests/mac/FontManagerTests.mm:204
Value of: attributesAreEqual
Actual: false
Expected: true
/Volumes/Data/worker/Apple-Ventura-Release-Build/build/Tools/TestWebKitAPI/Tests/mac/FontManagerTests.mm:204
Value of: attributesAreEqual
Actual: false
Expected: true
/Volumes/Data/worker/Apple-Ventura-Release-Build/build/Tools/TestWebKitAPI/Tests/mac/FontManagerTests.mm:204
Value of: attributesAreEqual
Actual: false
Expected: true
https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.FontManagerTests.ChangeFontWithPanel
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/105893191>
Myles C. Maxfield
Pull request: https://github.com/WebKit/WebKit/pull/10674
EWS
Test gardening commit 260826@main (7f06b13867ff): <https://commits.webkit.org/260826@main>
Reviewed commits have been landed. Closing PR #10674 and removing active labels.
Wenson Hsieh
Pull request: https://github.com/WebKit/WebKit/pull/10676
Seija K.
FYI: this happened because the original committer erroneously removed these lines:
[fontAttributes1 removeObjectForKey:NSFontVariationAttribute];
[fontAttributes2 removeObjectForKey:NSFontVariationAttribute];
EWS
Committed 260841@main (6d701f331859): <https://commits.webkit.org/260841@main>
Reviewed commits have been landed. Closing PR #10676 and removing active labels.