Bug 242586

Summary:	shadow-dom/nested-slot-remove-crash.html and other -crash tests are listed in resource-files.json
Product:	WebKit	Reporter:	Ryosuke Niwa <rniwa>
Component:	Tools / Tests	Assignee:	Ryosuke Niwa <rniwa>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	cdumez, gsnedders, webkit-bug-importer, youennf
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=221486 https://bugs.webkit.org/show_bug.cgi?id=242784

Ryosuke Niwa

Reported 2022-07-10 21:30:24 PDT

I noticed that this test is never ran / found by WebKit's run-webkit-tests because it's listed as a resource file in resource-files.json. What's up with that?

Attachments
Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2022-07-10 21:48:37 PDT

Looks like this is a very old bug in TestParser.analyze_test. It can't determine the test type so returns None. find_importable_tests would then classify it as a potential resource file.

Ryosuke Niwa

Comment 2 2022-07-10 23:09:13 PDT

Pull request: https://github.com/WebKit/WebKit/pull/2287

EWS

Comment 3 2022-07-11 12:51:43 PDT

Committed 252350@main (d8b1589e4915): <https://commits.webkit.org/252350@main> Reviewed commits have been landed. Closing PR #2287 and removing active labels.

Radar WebKit Bug Importer

Comment 4 2022-07-11 12:52:18 PDT

<rdar://problem/96838187>

Note You need to log in before you can comment on or make changes to this bug.