Bug 242230

Summary: REGRESSION(250469@main) svg/animations/animation-leak-list-property-instances.html is randomly failing
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: AnimationsAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, darin, dino, graouts, koivisto, svillar, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=242231
https://bugs.webkit.org/show_bug.cgi?id=114280
Attachments:
Description Flags
Patch
none
Patch none

Fujii Hironori
Reported 2022-06-30 23:44:44 PDT
REGRESSION(250469@main) svg/animations/animation-leak-list-property-instances.html is randomly failing https://results.webkit.org/?suite=layout-tests&test=svg%2Fanimations%2Fanimation-leak-list-property-instances.html Since 250469@main (bug#240112) modified animation-leak-list-property-instances.html.
Attachments
Patch (4.03 KB, patch)
2022-07-04 14:27 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (4.15 KB, patch)
2022-07-04 21:42 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2022-06-30 23:48:21 PDT
250480@main Buildbot: builder Apple-BigSur-Debug-WK2-Tests build 6491 https://build.webkit.org/#/builders/23/builds/6491 --- /Volumes/Data/worker/Apple-BigSur-Debug-WK2-Tests/build/layout-test-results/svg/animations/animation-leak-list-property-instances-expected.txt +++ /Volumes/Data/worker/Apple-BigSur-Debug-WK2-Tests/build/layout-test-results/svg/animations/animation-leak-list-property-instances-actual.txt @@ -3,5 +3,5 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS 0 is 0 +FAIL -63 should be 0. Was -63.
Fujii Hironori
Comment 2 2022-07-01 23:35:36 PDT
Another test failure. Buildbot: builder GTK-Linux-64-bit-Release-Skip-Failing-Tests build 6406: 252088@main https://build.webkit.org/#/builders/199/builds/6406 --- /home/buildbot/worker/GTK-Linux-64-bit-Release-Skip-Failing-Tests/build/layout-test-results/svg/animations/animation-leak-list-property-instances-expected.txt +++ /home/buildbot/worker/GTK-Linux-64-bit-Release-Skip-Failing-Tests/build/layout-test-results/svg/animations/animation-leak-list-property-instances-actual.txt @@ -3,8 +3,9 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS 0 is 0 +FAIL -7 should be 0. Was -7. PASS successfullyParsed is true +Some tests failed. TEST COMPLETE
Alexey Proskuryakov
Comment 3 2022-07-04 11:34:24 PDT
Bug 242231 fixed some obviously mistakes in the test, but now it's failing for apparently more substantial reasons.
Radar WebKit Bug Importer
Comment 4 2022-07-04 11:36:07 PDT
<rdar://problem/96403351>
Fujii Hironori
Comment 5 2022-07-04 14:27:10 PDT
Created attachment 460659 [details] Patch
Darin Adler
Comment 6 2022-07-04 21:16:11 PDT
Comment on attachment 460659 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=460659&action=review > LayoutTests/svg/animations/animation-leak-list-property-instances-expected.txt:6 > +PASS 0 is <= 5 This won’t work to make the test less flaky. Because if we have 1 this line will say "Pass 1 is <= 5" and the test will fail.
Darin Adler
Comment 7 2022-07-04 21:16:47 PDT
Comment on attachment 460659 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=460659&action=review >> LayoutTests/svg/animations/animation-leak-list-property-instances-expected.txt:6 >> +PASS 0 is <= 5 > > This won’t work to make the test less flaky. Because if we have 1 this line will say "Pass 1 is <= 5" and the test will fail. This needs to be changed so that the number of objects is not logged.
Fujii Hironori
Comment 8 2022-07-04 21:25:23 PDT
Comment on attachment 460659 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=460659&action=review >>> LayoutTests/svg/animations/animation-leak-list-property-instances-expected.txt:6 >>> +PASS 0 is <= 5 >> >> This won’t work to make the test less flaky. Because if we have 1 this line will say "Pass 1 is <= 5" and the test will fail. > > This needs to be changed so that the number of objects is not logged. Good catch. Will fix. Thank you very much.
Fujii Hironori
Comment 9 2022-07-04 21:42:55 PDT
Created attachment 460669 [details] Patch
Yusuke Suzuki
Comment 10 2022-07-05 12:51:23 PDT
Comment on attachment 460669 [details] Patch r=me
EWS
Comment 11 2022-07-05 15:06:24 PDT
Committed 252153@main (1b783a18fdac): <https://commits.webkit.org/252153@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460669 [details].
Note You need to log in before you can comment on or make changes to this bug.