Bug 233982

Summary: Add isMainThread() assertions to specializedChineseLocale
Product: WebKit Reporter: Cameron McCormack (:heycam) <heycam>
Component: Layout and RenderingAssignee: Cameron McCormack (:heycam) <heycam>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, mattwoodrow, mmaxfield, simon.fraser, webkit-bug-importer, ysuzuki, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 233488    
Attachments:
Description Flags
Patch
mmaxfield: review+
Patch
none
Patch none

Cameron McCormack (:heycam)
Reported 2021-12-07 22:52:52 PST
Add isMainThread() assertions to specializedChineseLocale
Attachments
Patch (1.91 KB, patch)
2021-12-07 22:53 PST, Cameron McCormack (:heycam) 		mmaxfield: review+
DetailsFormatted DiffDiff
Patch (2.82 KB, patch)
2022-07-19 15:50 PDT, Matt Woodrow 		no flags
DetailsFormatted DiffDiff
Patch (2.87 KB, patch)
2022-07-19 17:31 PDT, Matt Woodrow 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Cameron McCormack (:heycam)
Comment 1 2021-12-07 22:53:53 PST
Created attachment 446307 [details] Patch
Myles C. Maxfield
Comment 2 2021-12-08 21:14:46 PST
Comment on attachment 446307 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446307&action=review > Source/WebCore/platform/graphics/FontDescription.cpp:103 > void FontDescription::setSpecifiedLocale(const AtomString& locale) It looks like this function is exported, but no one outside of WebCore calls it. Can we make it not exported?
Radar WebKit Bug Importer
Comment 3 2021-12-14 22:53:15 PST
<rdar://problem/86507335>
Matt Woodrow
Comment 4 2022-07-19 15:50:12 PDT
Created attachment 461023 [details] Patch
Yusuke Suzuki
Comment 5 2022-07-19 16:49:46 PDT
BTW, you can use MainThreadNeverDestroyed for NeverDestoryed objects which is available only in MainThread.
Matt Woodrow
Comment 6 2022-07-19 17:31:05 PDT
Created attachment 461026 [details] Patch
EWS
Comment 7 2022-07-19 23:03:24 PDT
Committed 252637@main (5ba8177f9530): <https://commits.webkit.org/252637@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 461026 [details].
Note You need to log in before you can comment on or make changes to this bug.