Bug 233979

Summary: Make FontCascade::s_codePath thread safe
Product: WebKit Reporter: Cameron McCormack (:heycam) <heycam>
Component: Layout and RenderingAssignee: Matt Woodrow <mattwoodrow>
Status: NEW    
Severity: Normal CC: bfulgham, ews-watchlist, glenn, jbedard, mmaxfield, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 233488    
Attachments:
Description Flags
Patch
none
Patch mmaxfield: review+, ews-feeder: commit-queue-

Cameron McCormack (:heycam)
Reported 2021-12-07 22:30:11 PST
Make FontCascade::s_codePath thread safe
Attachments
Patch (2.40 KB, patch)
2021-12-07 22:40 PST, Cameron McCormack (:heycam) 		no flags
DetailsFormatted DiffDiff
Patch (31.13 KB, patch)
2021-12-09 21:48 PST, Cameron McCormack (:heycam) 		mmaxfield: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Cameron McCormack (:heycam)
Comment 1 2021-12-07 22:40:30 PST
Created attachment 446305 [details] Patch
Myles C. Maxfield
Comment 2 2021-12-08 21:09:07 PST
Comment on attachment 446305 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446305&action=review > Source/WebCore/ChangeLog:3 > + Make FontCascade::s_codePath thread safe Can we just delete it instead?
Cameron McCormack (:heycam)
Comment 3 2021-12-09 21:48:31 PST
Created attachment 446658 [details] Patch
Cameron McCormack (:heycam)
Comment 4 2021-12-09 21:49:19 PST
(In reply to Myles C. Maxfield from comment #2) > Can we just delete it instead? Let's try. It involves more code removal than I thought.
Radar WebKit Bug Importer
Comment 5 2021-12-14 22:31:16 PST
<rdar://problem/86506735>
Myles C. Maxfield
Comment 6 2022-09-07 19:43:27 PDT
Comment on attachment 446658 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446658&action=review I think this is right but I think we should run this by a GTK port contributor before landing. > Source/WebCore/ChangeLog:14 > + - making the Gtk port go back to effectively using CodePath::Auto I thought the GTK port _only_ had the complex text codepath. Maybe I'm misinformed?
Matt Woodrow
Comment 7 2022-09-11 16:21:50 PDT
Pull request: https://github.com/WebKit/WebKit/pull/4242
Note You need to log in before you can comment on or make changes to this bug.