Bug 233515

Summary:

GraphicsContextGLANGLE.cpp has platform specific code

Product:

WebKit

Reporter:

Kimmo Kinnunen <kkinnunen>

Component:

WebGL

Assignee:

Kimmo Kinnunen <kkinnunen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, cmarcelo, dino, ews-watchlist, fujii.hironori, gyuyoung.kim, kbr, kkinnunen, koivisto, kondapallykalyan, luiz, ryuan.choi, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

221664, 233589

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none

Kimmo Kinnunen

Reported 2021-11-26 00:25:45 PST

GraphicsContextGLANGLE.cpp has platform specific code This should be invoked through virtual functions and the code should be moved to the platform specific implementations This way platform specific implementation like GraphicsContextGLOpenGL Cocoa flavour can be in future be called GraphicsContextGLCocoa, since GraphicsContextGLOpenGL and GraphicsContextGLANGLE would be also separate classes.

Attachments
Patch (9.63 KB, patch) 2021-11-26 00:30 PST, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Patch (14.93 KB, patch) 2021-11-26 03:27 PST, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Patch (23.27 KB, patch) 2021-11-26 05:19 PST, Kimmo Kinnunen	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (23.27 KB, patch) 2021-11-26 05:24 PST, Kimmo Kinnunen	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (23.38 KB, patch) 2021-11-26 05:53 PST, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Patch (23.38 KB, patch) 2021-11-26 05:58 PST, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.