Bug 233498

Summary:

Unskip pointerevents layout tests

Product:

WebKit

Reporter:

Carlos Alberto Lopez Perez <clopez>

Component:

Tools / Tests

Assignee:

Carlos Alberto Lopez Perez <clopez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, dino, graouts, Morningstar, ryanhaddad, tsavell, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=214870
https://bugs.webkit.org/show_bug.cgi?id=191333
https://bugs.webkit.org/show_bug.cgi?id=193214

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Carlos Alberto Lopez Perez

Reported 2021-11-25 09:01:32 PST

On bug 214870 I got puzzled because the layout tests pointerevents/ios are skipped on the main TestExpectation files but they are not unskipped on iOS, neither on other port-specific TestExpectation file. Which means this tests are skipped everywhere. I double checked that by grepping pointerevents/ios on the stdio of the layout test step here https://build.webkit.org/#/builders/268/builds/554 Let's try to enable them to see what happens.

Attachments
Patch (1.12 KB, patch) 2021-11-25 09:10 PST, Carlos Alberto Lopez Perez	no flags	Details Formatted Diff Diff
Patch (1.68 KB, patch) 2021-11-25 11:52 PST, Carlos Alberto Lopez Perez	no flags	Details Formatted Diff Diff
Patch (2.09 KB, patch) 2021-11-25 21:10 PST, Carlos Alberto Lopez Perez	no flags	Details Formatted Diff Diff
Patch (3.00 KB, patch) 2021-12-01 10:10 PST, Carlos Alberto Lopez Perez	no flags	Details Formatted Diff Diff
Patch (3.02 KB, patch) 2021-12-09 06:21 PST, Carlos Alberto Lopez Perez	no flags	Details Formatted Diff Diff
Patch (3.48 KB, patch) 2021-12-15 17:07 PST, Carlos Alberto Lopez Perez	no flags	Details Formatted Diff Diff
Patch (3.56 KB, patch) 2021-12-16 22:30 PST, Carlos Alberto Lopez Perez	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Carlos Alberto Lopez Perez

Comment 1 2021-11-25 09:07:02 PST

The commit that skipped this tests was r238274

Carlos Alberto Lopez Perez

Comment 2 2021-11-25 09:10:16 PST

Created attachment 445141 [details] Patch try to unskip pointerevents/ios for all platforms to see what happens

Carlos Alberto Lopez Perez

Comment 3 2021-11-25 11:50:57 PST

Ok.. this is even weirder.. the whole pointerevents tests are skipped since r239732 :? so the above patch had no effect at all

Carlos Alberto Lopez Perez

Comment 4 2021-11-25 11:52:36 PST

Created attachment 445151 [details] Patch try to unskip pointerevents for all platforms to see what happens

Carlos Alberto Lopez Perez

Comment 5 2021-11-25 21:10:37 PST

Created attachment 445168 [details] Patch

Alexey Proskuryakov

Comment 6 2021-11-28 18:16:48 PST

It sounds like they are expected to be skipped, per bug 193214 comment 5. > Ok.. this is even weirder.. the whole pointerevents tests are skipped since r239732 :? so the above patch had no effect at all I think that you may mean r239704, as that's what skipped all of pointerevents everywhere. This is what the ChangeLog said, but it didn't say why.

Carlos Alberto Lopez Perez

Comment 7 2021-12-01 10:02:34 PST

(In reply to Alexey Proskuryakov from comment #6) > It sounds like they are expected to be skipped, per bug 193214 comment 5. > > > Ok.. this is even weirder.. the whole pointerevents tests are skipped since r239732 :? so the above patch had no effect at all > > I think that you may mean r239704, as that's what skipped all of > pointerevents everywhere. This is what the ChangeLog said, but it didn't say > why. The thing is that later r239732 reverted the change to LayoutTests/platform/ios-wk2/TestExpectations effectively skipping pointerevent tests also on iOS

Carlos Alberto Lopez Perez

Comment 8 2021-12-01 10:10:33 PST

Created attachment 445588 [details] Patch

Alexey Proskuryakov

Comment 9 2021-12-01 12:08:06 PST

Right, they are expected to be skipped on iOS. I am not qualified to discuss the reasons, beyond pointing out bug 193214 comment 5.

Radar WebKit Bug Importer

Comment 10 2021-12-02 09:02:27 PST

<rdar://problem/85973701>

Carlos Alberto Lopez Perez

Comment 11 2021-12-09 06:21:05 PST

Created attachment 446534 [details] Patch