Bug 230181

Summary: [WK2] Reduce amount of IPC needed by BroadcastChannel
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, darin, esprehn+autocc, ews-watchlist, ggaren, kangil.han, kkinnunen, sam, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 161472, 228089    
Attachments:
Description Flags
WIP patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2021-09-10 16:50:51 PDT
Avoid doing IPC for BroadcastChannel when the destination is within the same process.
Attachments
WIP patch (9.95 KB, patch)
2021-09-10 16:56 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (23.41 KB, patch)
2021-09-11 00:05 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (24.19 KB, patch)
2021-09-11 09:16 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (24.31 KB, patch)
2021-09-13 16:10 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-09-10 16:56:47 PDT
Created attachment 437925 [details] WIP patch
Chris Dumez
Comment 2 2021-09-11 00:05:24 PDT
Created attachment 437943 [details] Patch
Chris Dumez
Comment 3 2021-09-11 09:16:57 PDT
Created attachment 437953 [details] Patch
Alex Christensen
Comment 4 2021-09-13 13:14:22 PDT
Comment on attachment 437953 [details] Patch I'm assuming this already handles the case where a process crashes, right?
Chris Dumez
Comment 5 2021-09-13 13:17:34 PDT
(In reply to Alex Christensen from comment #4) > Comment on attachment 437953 [details] > Patch > > I'm assuming this already handles the case where a process crashes, right? No, we don't currently have good handling for network process crashes, meaning that the BroadcastChannelRegistry doesn't get repopulated after a network process relaunch. This is something we should improve but: 1. I don't think it is made worse by this patch (if anything it is better because messaging between BroadcastChannels inside the same WebProcess will still work after a network process relaunch). 2. I suspect we have issues for MessagePort.
Chris Dumez
Comment 6 2021-09-13 16:10:14 PDT
Created attachment 438086 [details] Patch
Chris Dumez
Comment 7 2021-09-13 16:27:25 PDT
(In reply to Alex Christensen from comment #4) > Comment on attachment 437953 [details] > Patch > > I'm assuming this already handles the case where a process crashes, right? I filed Bug 230236 to track this issue. Will fix in a follow-up.
EWS
Comment 8 2021-09-13 21:15:50 PDT
Committed r282377 (241639@main): <https://commits.webkit.org/241639@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438086 [details].
Radar WebKit Bug Importer
Comment 9 2021-09-13 21:16:17 PDT
<rdar://problem/83086565>
Note You need to log in before you can comment on or make changes to this bug.