Bug 228951

Summary: Cherry-pick ANGLE: Revise WebGL's shaderSource validation
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: ANGLEAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, kbr, kkinnunen, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=229051
Bug Depends on:    
Bug Blocks: 223315    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Kimmo Kinnunen
Reported 2021-08-10 06:06:11 PDT
Cherry-pick ANGLE: Revise WebGL's shaderSource validation
Attachments
Patch (12.35 KB, patch)
2021-08-10 06:12 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch (12.84 KB, patch)
2021-08-10 06:52 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch (12.61 KB, patch)
2021-08-10 11:57 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch for landing (12.66 KB, patch)
2021-08-10 22:45 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1 2021-08-10 06:12:03 PDT
Created attachment 435251 [details] Patch
Kimmo Kinnunen
Comment 2 2021-08-10 06:52:36 PDT
Created attachment 435254 [details] Patch
Kimmo Kinnunen
Comment 3 2021-08-10 11:57:11 PDT
Created attachment 435278 [details] Patch
EWS Watchlist
Comment 4 2021-08-10 11:58:06 PDT
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Kenneth Russell
Comment 5 2021-08-10 13:00:41 PDT
Comment on attachment 435278 [details] Patch Looks good; verified that WebGLRenderingContextBase is just passing through these shader sources to ANGLE rather than doing any processing like it used to. r+
Kimmo Kinnunen
Comment 6 2021-08-10 22:45:37 PDT
Created attachment 435324 [details] Patch for landing
EWS
Comment 7 2021-08-11 04:21:01 PDT
Committed r280904 (240428@main): <https://commits.webkit.org/240428@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435324 [details].
Radar WebKit Bug Importer
Comment 8 2021-08-11 04:21:29 PDT
<rdar://problem/81787531>
Note You need to log in before you can comment on or make changes to this bug.