Bug 227655

Summary: [OpenSSL] Implement CryptoAlgorithmEC*
Product: WebKit Reporter: Yoshiaki Jitsukawa <yoshiaki.jitsukawa>
Component: PlatformAssignee: Yoshiaki Jitsukawa <yoshiaki.jitsukawa>
Status: RESOLVED FIXED    
Severity: Normal CC: don.olmstead, ews-watchlist, jiewen_tan, stephan.szabo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 206439    
Attachments:
Description Flags
Patch
none
Patch none

Yoshiaki Jitsukawa
Reported 2021-07-03 00:53:58 PDT
Implement elliptic curve things.
Attachments
Patch (58.51 KB, patch)
2021-07-06 05:49 PDT, Yoshiaki Jitsukawa 		no flags
DetailsFormatted DiffDiff
Patch (58.53 KB, patch)
2021-07-06 17:19 PDT, Yoshiaki Jitsukawa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yoshiaki Jitsukawa
Comment 1 2021-07-06 05:49:16 PDT
Created attachment 432919 [details] Patch
Stephan Szabo
Comment 2 2021-07-06 08:10:03 PDT
Comment on attachment 432919 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432919&action=review > Source/WebCore/crypto/openssl/CryptoKeyECOpenSSL.cpp:272 > + return false; This seems like it should be a return nullptr; Appears to cause a failure for me on playstation complaining about no viable conversion from returned value of type 'bool' to function return type 'RefPtr<WebCore::CryptoKeyEC>.
Yoshiaki Jitsukawa
Comment 3 2021-07-06 17:19:27 PDT
Created attachment 432990 [details] Patch
Yoshiaki Jitsukawa
Comment 4 2021-07-06 17:22:39 PDT
> This seems like it should be a return nullptr; Thanks, I fixed it with the new patch along with warning fixes of ptrdiff vs size_t comparison in CryptoKeyEC::platformImportSpki/Pkcs8().
EWS
Comment 5 2021-07-07 15:52:43 PDT
Committed r279682 (239487@main): <https://commits.webkit.org/239487@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432990 [details].
Radar WebKit Bug Importer
Comment 6 2021-07-07 15:53:18 PDT
<rdar://problem/80293316>
Note You need to log in before you can comment on or make changes to this bug.