Bug 222624

Summary: Fix Depth24 Stencil8 support on Simulator for Metal Angle backend
Product: WebKit Reporter: Kyle Piddington <kpiddington>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, graouts, jonlee, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 220076    
Attachments:
Description Flags
Patch dino: review+

Kyle Piddington
Reported 2021-03-02 15:34:08 PST
Fix Depth24 Stencil8 support on Simulator for Metal Angle backend
Attachments
Patch (72.39 KB, patch)
2021-03-02 15:34 PST, Kyle Piddington 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kyle Piddington
Comment 1 2021-03-02 15:34:24 PST
Created attachment 422007 [details] Patch
EWS Watchlist
Comment 2 2021-03-02 15:35:38 PST
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Dean Jackson
Comment 3 2021-03-03 10:29:27 PST
Comment on attachment 422007 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422007&action=review > Source/ThirdParty/ANGLE/ChangeLog:9 > + Fixes the following tests: > + fast/canvas/webgl/context-creation-attributes.html > + fast/canvas/webgl/webgl-depth-texture.html > + webgl/1.0.3/conformance/misc/webgl-specific.html > + webgl/1.0.3/conformance/renderbuffers/framebuffer-object-attachment.html FYI: Seems like your editor is using tabs, which will be rejected by the commit check. > Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_format_table_autogen.mm:40 > - > + Did all these spaces come from an update to the script?
Dean Jackson
Comment 4 2021-03-03 10:58:13 PST
Committed r273823
Radar WebKit Bug Importer
Comment 5 2021-03-03 10:59:24 PST
<rdar://problem/74993209>
Note You need to log in before you can comment on or make changes to this bug.