Bug 220318

Summary: WebKit IPC builtin messages should be part of the model
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebKit2Assignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 220236    
Bug Blocks: 217211, 220319    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Kimmo Kinnunen
Reported 2021-01-05 03:19:03 PST
WebKit IPC builtin messages should be part of the model This way the generator can operate on all the messages, not just all non-builtin messages
Attachments
Patch (37.16 KB, patch)
2021-01-05 03:23 PST, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch (37.17 KB, patch)
2021-01-05 04:38 PST, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch (81.02 KB, patch)
2021-01-07 01:52 PST, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1 2021-01-05 03:23:53 PST
Created attachment 416987 [details] Patch
Kimmo Kinnunen
Comment 2 2021-01-05 04:38:43 PST
Created attachment 416991 [details] Patch
Chris Dumez
Comment 3 2021-01-06 07:31:38 PST
This seems to be failing the tests.
Kimmo Kinnunen
Comment 4 2021-01-07 01:52:53 PST
Created attachment 417170 [details] Patch
Kimmo Kinnunen
Comment 5 2021-01-07 08:01:31 PST
(In reply to Chris Dumez from comment #3) > This seems to be failing the tests. Sorry, updated and added some tests around the issue.
EWS
Comment 6 2021-01-07 09:04:26 PST
Committed r271237: <https://trac.webkit.org/changeset/271237> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417170 [details].
Radar WebKit Bug Importer
Comment 7 2021-01-07 09:05:19 PST
<rdar://problem/72891299>
Note You need to log in before you can comment on or make changes to this bug.