Bug 210364

Summary: When drawing an image srcRect and imageRect have to be in the orientation of destRect
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: ImagesAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=209849
https://bugs.webkit.org/show_bug.cgi?id=210371
Attachments:
Description Flags
Patch none

Said Abou-Hallawa
Reported 2020-04-10 17:32:58 PDT
When passing ImageOrientation::None to any drawImage() function, srcRect and imageRect have to be calculated with this orientation. There are few places where the size of the image is calculated with ImageOrientation::FromImage because it is the default.
Attachments
Patch (10.72 KB, patch)
2020-04-10 17:55 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2020-04-10 17:55:56 PDT
Created attachment 396140 [details] Patch
EWS
Comment 2 2020-04-13 09:43:26 PDT
Committed r260016: <https://trac.webkit.org/changeset/260016> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396140 [details].
Radar WebKit Bug Importer
Comment 3 2020-04-13 09:44:17 PDT
<rdar://problem/61720495>
Antoine Quint
Comment 4 2020-05-01 01:33:31 PDT
This was reverted in r260989.
Said Abou-Hallawa
Comment 5 2020-05-08 14:33:45 PDT
It was reinstated in: Committed r261162: <https://trac.webkit.org/changeset/261162>
Note You need to log in before you can comment on or make changes to this bug.