Bug 209200

Summary: Web Inspector: the width of `WI.TabBarItem` can change if the detached window is resized
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=204627
Bug Depends on: 208603    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Devin Rousso
Reported 2020-03-17 15:20:08 PDT
From my comment <https://webkit.org/b/204627#c56>: > We shouldn't need to worry about the value stored in `[WI.TabBar.CachedWidthSymbol]` changing anymore (meaning we don't need to reset it), as we no longer hide icons, meaning that the width of every `WI.TabBarItem` should be constant. This isn't completely accurate, as we don't shrink `WI.TabBarItem` to their minimum width when detached.
Attachments
Patch (4.53 KB, patch)
2020-03-17 15:39 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2020-03-17 15:39:58 PDT
Created attachment 393797 [details] Patch
WebKit Commit Bot
Comment 2 2020-03-17 21:30:27 PDT
Comment on attachment 393797 [details] Patch Clearing flags on attachment: 393797 Committed r258623: <https://trac.webkit.org/changeset/258623>
WebKit Commit Bot
Comment 3 2020-03-17 21:30:28 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2020-03-17 21:31:15 PDT
<rdar://problem/60569940>
Note You need to log in before you can comment on or make changes to this bug.