Bug 208895

Summary: Introduce ResourceLoadStatisticsParameters and move members from NetworkSessionCreationParameters
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, mmaxfield, webkit-bug-importer, wilander, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Alex Christensen
Reported 2020-03-10 16:56:42 PDT
Introduce ResourceLoadStatisticsParameters and move members from NetworkSessionCreationParameters
Attachments
Patch (33.16 KB, patch)
2020-03-10 16:58 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (31.91 KB, patch)
2020-03-11 09:44 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-03-10 16:58:17 PDT
Created attachment 393187 [details] Patch
youenn fablet
Comment 2 2020-03-11 06:54:35 PDT
Comment on attachment 393187 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393187&action=review > Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1176 > + setResourceLoadStatisticsEnabled(parameters.resourceLoadStatisticsParameters.enableResourceLoadStatistics); Since this is a NetworkSessionCreationParameters&&, we could move some of these values, like m_resourceLoadStatisticsDirectory > Source/WebKit/Shared/ResourceLoadStatisticsParameters.h:36 > +struct ResourceLoadStatisticsParameters { Given we have ResourceLoadStatistics inside ResourceLoadStatisticsParameters, could we remove ResourceLoadStatistics from the parameter names. For instance s/resourceLoadStatisticsDirectory/directoy and s/resourceLoadStatisticsDirectoryExtensionHandle/directoryExtensionHandle.
Alex Christensen
Comment 3 2020-03-11 09:44:12 PDT
Created attachment 393255 [details] Patch
John Wilander
Comment 4 2020-03-11 10:04:51 PDT
It looks good to me too.
WebKit Commit Bot
Comment 5 2020-03-11 10:42:03 PDT
The commit-queue encountered the following flaky tests while processing attachment 393255 [details]: imported/w3c/web-platform-tests/IndexedDB/fire-success-event-exception.html bug 206554 (authors: shvaikalesh@gmail.com and youennf@gmail.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2020-03-11 10:42:43 PDT
Comment on attachment 393255 [details] Patch Clearing flags on attachment: 393255 Committed r258269: <https://trac.webkit.org/changeset/258269>
WebKit Commit Bot
Comment 7 2020-03-11 10:42:45 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2020-03-11 10:43:13 PDT
<rdar://problem/60330048>
Myles C. Maxfield
Comment 9 2020-03-11 12:45:28 PDT
I think this patch is breaking Apple's internal builds.
Alex Christensen
Comment 10 2020-03-11 12:50:01 PDT
I believe I fixed that.
Note You need to log in before you can comment on or make changes to this bug.