Bug 207348

Summary: ResourceLoadStatisticsDatabaseStore::dumpResourceLoadStatistics relies on the order of m_getAllDomainsStatement, which can be changed by HashTable's implementation
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, mark.lam, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Yusuke Suzuki
Reported 2020-02-06 12:51:04 PST
ResourceLoadStatisticsDatabaseStore::dumpResourceLoadStatistics relies on the order of m_getAllDomainsStatement, which can be changed by HashTable's implementation
Attachments
Patch (2.25 KB, patch)
2020-02-06 12:52 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2020-02-06 12:52:16 PST
Created attachment 389983 [details] Patch
Mark Lam
Comment 2 2020-02-06 14:12:21 PST
Comment on attachment 389983 [details] Patch r=me. Is the test already expecting sorted order? If not, you should rebase the test results also.
Yusuke Suzuki
Comment 3 2020-02-06 14:19:39 PST
(In reply to Mark Lam from comment #2) > Comment on attachment 389983 [details] > Patch > > r=me. Is the test already expecting sorted order? If not, you should > rebase the test results also. Yes, luckily :)
WebKit Commit Bot
Comment 4 2020-02-06 14:58:43 PST
The commit-queue encountered the following flaky tests while processing attachment 389983 [details]: imported/w3c/web-platform-tests/web-animations/timing-model/timelines/update-and-send-events-replacement.html bug 207335 (author: graouts@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2020-02-06 14:59:08 PST
The commit-queue encountered the following flaky tests while processing attachment 389983 [details]: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2020-02-06 19:08:44 PST
Comment on attachment 389983 [details] Patch Clearing flags on attachment: 389983 Committed r256002: <https://trac.webkit.org/changeset/256002>
WebKit Commit Bot
Comment 7 2020-02-06 19:08:45 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2020-02-06 19:09:14 PST
<rdar://problem/59248444>
Note You need to log in before you can comment on or make changes to this bug.