Bug 203484

Summary: CSS Transitions and CSS Animations properties should treat unitless 0 as an invalid value for times
Product: WebKit Reporter: Antoine Quint <graouts>
Component: AnimationsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, koivisto, macpherson, menard, nickshanks, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=113230
https://bugs.webkit.org/show_bug.cgi?id=155870
https://bugs.webkit.org/show_bug.cgi?id=141023
Bug Depends on:    
Bug Blocks: 203477    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews213 for win-future
none
Patch none

Antoine Quint
Reported 2019-10-28 03:20:47 PDT
CSS Transitions and CSS Animations properties should treat unitless 0 as an invalid value for times
Attachments
Patch (9.63 KB, patch)
2019-10-28 03:23 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews213 for win-future (14.26 MB, application/zip)
2019-10-28 04:41 PDT, EWS Watchlist 		no flags
Details
Patch (18.66 KB, patch)
2019-10-28 08:34 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2019-10-28 03:23:34 PDT
Created attachment 382060 [details] Patch
Antti Koivisto
Comment 2 2019-10-28 03:26:57 PDT
Comment on attachment 382060 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382060&action=review > Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:450 > + bool acceptUnitless = token.type() == NumberToken && unitless == UnitlessQuirk::Allow && shouldAcceptUnitlessValue(token.numericValue(), cssParserMode, unitless); Why does it still need to be accepted in quirks mode?
Antoine Quint
Comment 3 2019-10-28 03:32:02 PDT
(In reply to Antti Koivisto from comment #2) > Comment on attachment 382060 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=382060&action=review > > > Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:450 > > + bool acceptUnitless = token.type() == NumberToken && unitless == UnitlessQuirk::Allow && shouldAcceptUnitlessValue(token.numericValue(), cssParserMode, unitless); > > Why does it still need to be accepted in quirks mode? This is so -webkit-marquee-speed, which is the only property for which UnitlessQuirk is set to Allow, does not change behavior. Only transition-delay, animation-duration and animation-delay are affected.
EWS Watchlist
Comment 4 2019-10-28 04:41:25 PDT
Comment on attachment 382060 [details] Patch Attachment 382060 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13184947 New failing tests: css1/units/zero-duration-without-units.html transitions/zero-duration-without-units.html animations/fill-mode-forwards-zero-duration.html legacy-animation-engine/animations/fill-mode-forwards-zero-duration.html css3/filters/blur-various-radii.html legacy-animation-engine/compositing/animation/keyframe-order.html transitions/zero-duration-in-list.html
EWS Watchlist
Comment 5 2019-10-28 04:41:27 PDT
Created attachment 382066 [details] Archive of layout-test-results from ews213 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews213 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Antoine Quint
Comment 6 2019-10-28 08:34:47 PDT
Created attachment 382073 [details] Patch
Antoine Quint
Comment 7 2019-10-28 10:02:05 PDT
Committed r251658: <https://trac.webkit.org/changeset/251658>
Radar WebKit Bug Importer
Comment 8 2019-10-28 10:03:18 PDT
<rdar://problem/56672826>
Antoine Quint
Comment 9 2019-12-09 01:37:25 PST
*** Bug 204947 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.