Bug 202632

Summary: [CSS Shadow Parts] Implement style invalidation
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cmarcelo, commit-queue, dbates, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kangil.han, macpherson, menard, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149443    
Attachments:
Description Flags
patch
rniwa: review+
patch none

Antti Koivisto
Reported 2019-10-07 05:29:03 PDT
::part() style should be invalidated on DOM mutations.
Attachments
patch (15.00 KB, patch)
2019-10-07 05:49 PDT, Antti Koivisto 		rniwa: review+
DetailsFormatted DiffDiff
patch (21.22 KB, patch)
2019-10-08 03:49 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2019-10-07 05:49:21 PDT
Created attachment 380316 [details] patch
Ryosuke Niwa
Comment 2 2019-10-07 13:49:07 PDT
Comment on attachment 380316 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=380316&action=review > LayoutTests/ChangeLog:10 > + * fast/css/shadow-parts/invalidation-class-descendant-combinator-expected.txt: Added. Can we also add tests for sibling combinators (+ & ~) as well as pseudo class like :hover and :active?
Antti Koivisto
Comment 3 2019-10-08 03:49:15 PDT
Created attachment 380418 [details] patch
Antti Koivisto
Comment 4 2019-10-08 04:37:58 PDT
> Can we also add tests for sibling combinators (+ & ~) as well as pseudo > class like :hover and :active? Added sibling combinator tests in this patch.
WebKit Commit Bot
Comment 5 2019-10-08 05:22:28 PDT
Comment on attachment 380418 [details] patch Clearing flags on attachment: 380418 Committed r250821: <https://trac.webkit.org/changeset/250821>
WebKit Commit Bot
Comment 6 2019-10-08 05:22:30 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-10-08 05:23:14 PDT
<rdar://problem/56071065>
Note You need to log in before you can comment on or make changes to this bug.