Bug 202562

Summary: Node::ref/deref should be const
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kangil.han, macpherson, menard, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
rniwa: review+
patch none

Antti Koivisto
Reported 2019-10-03 22:39:56 PDT
So you can have RefPtr<const Element>. This matches RefCounted.
Attachments
patch (16.93 KB, patch)
2019-10-04 02:22 PDT, Antti Koivisto 		rniwa: review+
DetailsFormatted DiffDiff
patch (16.92 KB, patch)
2019-10-06 02:14 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2019-10-03 22:41:38 PDT
Makes sense.
Antti Koivisto
Comment 2 2019-10-04 02:22:14 PDT
Created attachment 380203 [details] patch
Ryosuke Niwa
Comment 3 2019-10-04 11:57:38 PDT
Comment on attachment 380203 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=380203&action=review > Source/WebCore/css/ElementRuleCollector.h:105 > + RefPtr<const Element> m_shadowHostInPartRuleScope { nullptr }; No need for { ~ }.
Antti Koivisto
Comment 4 2019-10-06 02:14:00 PDT
Created attachment 380293 [details] patch
WebKit Commit Bot
Comment 5 2019-10-06 02:57:48 PDT
Comment on attachment 380293 [details] patch Clearing flags on attachment: 380293 Committed r250768: <https://trac.webkit.org/changeset/250768>
WebKit Commit Bot
Comment 6 2019-10-06 02:57:50 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-10-06 02:58:14 PDT
<rdar://problem/56015817>
Note You need to log in before you can comment on or make changes to this bug.