Bug 201714

Summary: REGRESSION? (r249786): inspector/canvas/context-attributes.html is failing on macOS WK1
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=201650
Attachments:
Description Flags
Patch none

Ryan Haddad
Reported 2019-09-11 22:12:52 PDT
inspector/canvas/context-attributes.html is failing on macOS WK1 after r249786 with the following diff: --- /Volumes/Data/slave/mojave-release-tests-wk1/build/layout-test-results/inspector/canvas/context-attributes-expected.txt +++ /Volumes/Data/slave/mojave-release-tests-wk1/build/layout-test-results/inspector/canvas/context-attributes-actual.txt @@ -32,7 +32,7 @@ "antialias": true, "premultipliedAlpha": true, "preserveDrawingBuffer": false, - "powerPreference": "default", + "powerPreference": "low-power", "failIfMajorPerformanceCaveat": false } @@ -46,7 +46,7 @@ "antialias": true, "premultipliedAlpha": true, "preserveDrawingBuffer": false, - "powerPreference": "default", + "powerPreference": "low-power", "failIfMajorPerformanceCaveat": false } PASS: Canvas context should have attribute "alpha" with value "false". https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fcanvas%2Fcontext-attributes.html
Attachments
Patch (2.88 KB, patch)
2019-09-12 03:30 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-09-11 22:13:05 PDT
<rdar://problem/55290473>
Ryan Haddad
Comment 2 2019-09-11 22:14:09 PDT
Devin, should the test be rebaselined for WK1, or is this unexpected?
Joseph Pecoraro
Comment 3 2019-09-11 22:27:13 PDT
(In reply to Ryan Haddad from comment #2) > Devin, should the test be rebaselined for WK1, or is this unexpected? WK1 (or perhaps specifically Mac WK1) will apparently need its own results since WebKitLegacy forces low-power: WebPreferences.mm: @YES, WebKitForceWebGLUsesLowPowerPreferenceKey, WK2 does not force low-power and uses the default WebCore::Setting values.
Devin Rousso
Comment 4 2019-09-11 22:30:45 PDT
(In reply to Ryan Haddad from comment #2) > Devin, should the test be rebaselined for WK1, or is this unexpected? No, this is unexpected, but not wrong. Apparently WK1 forces any WebGL/WebGL2 <canvas> to be "low-power", regardless of whatever value is asked for. I'll change the test to just filter out the `powerPreference` so long as it's one of the known possible values.
Devin Rousso
Comment 5 2019-09-12 03:30:45 PDT
Created attachment 378638 [details] Patch
Joseph Pecoraro
Comment 6 2019-09-12 07:25:27 PDT
Comment on attachment 378638 [details] Patch I liked seeing default. We could check in WK1 results. But this is fine
WebKit Commit Bot
Comment 7 2019-09-12 08:09:38 PDT
Comment on attachment 378638 [details] Patch Clearing flags on attachment: 378638 Committed r249809: <https://trac.webkit.org/changeset/249809>
WebKit Commit Bot
Comment 8 2019-09-12 08:09:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.