Bug 199526

Summary:

[SVG2]: Add length, item getter and item setter to all SVG lists

Product:

WebKit

Reporter:

Said Abou-Hallawa <sabouhallawa>

Component:

SVG

Assignee:

Said Abou-Hallawa <sabouhallawa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino, ews-watchlist, krit, rniwa, simon.fraser, thorton, webkit-bug-importer, zimmermann

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

191292

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews102 for mac-highsierra	none
Archive of layout-test-results from ews106 for mac-highsierra-wk2	none
Archive of layout-test-results from ews113 for mac-highsierra	none
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
Archive of layout-test-results from ews212 for win-future	none
Patch	none
Patch	none
Patch	none
Patch	none

Said Abou-Hallawa

Reported 2019-07-05 12:41:49 PDT

Implement the SVG2 specs for SVG lists: https://svgwg.org/svg2-draft/types.html#TermListInterface.

Attachments
Patch (16.49 KB, patch) 2019-07-05 12:45 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-highsierra (3.39 MB, application/zip) 2019-07-05 13:29 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (2.81 MB, application/zip) 2019-07-05 14:04 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews113 for mac-highsierra (3.03 MB, application/zip) 2019-07-05 14:30 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (2.66 MB, application/zip) 2019-07-05 14:44 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews212 for win-future (13.74 MB, application/zip) 2019-07-05 14:53 PDT, EWS Watchlist	no flags	Details
Patch (44.09 KB, patch) 2019-07-05 16:19 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Patch (51.08 KB, patch) 2019-08-27 13:46 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Patch (52.72 KB, patch) 2019-08-27 14:32 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Patch (52.67 KB, patch) 2019-08-27 18:29 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.

Said Abou-Hallawa

Comment 1 2019-07-05 12:45:03 PDT

Created attachment 373525 [details] Patch

EWS Watchlist

Comment 2 2019-07-05 13:29:50 PDT

Comment on attachment 373525 [details] Patch Attachment 373525 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12670304 New failing tests: svg/dom/SVGPointList-basics.xhtml svg/dom/SVGLengthList-basics.xhtml svg/dom/SVGTransformList-basics.xhtml svg/custom/polyline-points-crash.html svg/dom/SVGNumberList-basics.xhtml

EWS Watchlist

Comment 3 2019-07-05 13:29:52 PDT

Created attachment 373529 [details] Archive of layout-test-results from ews102 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 4 2019-07-05 14:04:44 PDT

Comment on attachment 373525 [details] Patch Attachment 373525 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12670462 New failing tests: svg/dom/SVGPointList-basics.xhtml svg/dom/SVGLengthList-basics.xhtml svg/dom/SVGTransformList-basics.xhtml svg/custom/polyline-points-crash.html svg/dom/SVGNumberList-basics.xhtml

EWS Watchlist

Comment 5 2019-07-05 14:04:46 PDT

Created attachment 373534 [details] Archive of layout-test-results from ews106 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 6 2019-07-05 14:30:33 PDT

Comment on attachment 373525 [details] Patch Attachment 373525 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12670467 New failing tests: svg/dom/SVGPointList-basics.xhtml svg/dom/SVGLengthList-basics.xhtml svg/dom/SVGTransformList-basics.xhtml svg/custom/polyline-points-crash.html svg/dom/SVGNumberList-basics.xhtml

EWS Watchlist

Comment 7 2019-07-05 14:30:35 PDT

Created attachment 373538 [details] Archive of layout-test-results from ews113 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 8 2019-07-05 14:44:17 PDT

Comment on attachment 373525 [details] Patch Attachment 373525 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12670481 New failing tests: svg/dom/SVGPointList-basics.xhtml svg/dom/SVGLengthList-basics.xhtml svg/dom/SVGTransformList-basics.xhtml svg/custom/polyline-points-crash.html svg/dom/SVGNumberList-basics.xhtml

EWS Watchlist

Comment 9 2019-07-05 14:44:19 PDT

Created attachment 373539 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5

EWS Watchlist

Comment 10 2019-07-05 14:53:41 PDT

Comment on attachment 373525 [details] Patch Attachment 373525 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12670553 New failing tests: svg/dom/SVGPointList-basics.xhtml svg/dom/SVGLengthList-basics.xhtml svg/dom/SVGTransformList-basics.xhtml svg/custom/polyline-points-crash.html svg/dom/SVGNumberList-basics.xhtml

EWS Watchlist

Comment 11 2019-07-05 14:53:43 PDT

Created attachment 373540 [details] Archive of layout-test-results from ews212 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews212 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Said Abou-Hallawa

Comment 12 2019-07-05 16:19:03 PDT

Created attachment 373551 [details] Patch

Said Abou-Hallawa

Comment 13 2019-08-27 13:46:47 PDT

Created attachment 377376 [details] Patch

Said Abou-Hallawa

Comment 14 2019-08-27 14:32:22 PDT

Created attachment 377385 [details] Patch

WebKit Commit Bot

Comment 15 2019-08-27 16:14:19 PDT

Comment on attachment 377385 [details] Patch Rejecting attachment 377385 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 5000 characters of output: REMOTE_INSPECTOR -DENABLE_RESIZE_OBSERVER -DENABLE_RESOURCE_LOAD_STATISTICS -DENABLE_RESOURCE_USAGE -DENABLE_RUBBER_BANDING -DENABLE_SANDBOX_EXTENSIONS -DENABLE_SERVER_PRECONNECT -DENABLE_SERVICE_CONTROLS -DENABLE_SERVICE_WORKER -DENABLE_SHAREABLE_RESOURCE -DENABLE_SPEECH_SYNTHESIS -DENABLE_STREAMS_API -DENABLE_SVG_FONTS -DENABLE_TELEPHONE_NUMBER_DETECTION -DENABLE_TEXT_AUTOSIZING -DENABLE_USERSELECT_ALL -DENABLE_USER_MESSAGE_HANDLERS -DENABLE_VARIATION_FONTS -DENABLE_VIDEO -DENABLE_VIDEO_PRESENTATION_MODE -DENABLE_VIDEO_TRACK -DENABLE_VIDEO_USES_ELEMENT_FULLSCREEN -DENABLE_WEBDRIVER_MOUSE_INTERACTIONS -DENABLE_WEBDRIVER_KEYBOARD_INTERACTIONS -DENABLE_WEBGL -DENABLE_WEBGL2 -DENABLE_WEB_AUDIO -DENABLE_WEB_AUTHN -DENABLE_WEB_CRYPTO -DENABLE_WEB_PROCESS_SANDBOX -DENABLE_WEB_RTC -DENABLE_WIRELESS_PLAYBACK_TARGET -DENABLE_XSLT -DBUILDING_WEBKIT -DU_DISABLE_RENAMING=1 -DU_SHOW_CPLUSPLUS_API=0 -DGL_SILENCE_DEPRECATION=1 -DGLES_SILENCE_DEPRECATION=1 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk -fasm-blocks -fstrict-aliasing -Wdeprecated-declarations -Winvalid-offsetof -mmacosx-version-min=10.13 -g -fvisibility=hidden -fvisibility-inlines-hidden -fno-threadsafe-statics -Wno-sign-conversion -Winfinite-recursion -Wmove -Wcomma -Wblock-capture-autoreleasing -Wstrict-prototypes -Wrange-loop-analysis -Wno-semicolon-before-method-body -iquote /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/WebCore-generated-files.hmap -I/Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/WebCore-own-target-headers.hmap -I/Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/WebCore-all-target-headers.hmap -iquote /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/WebCore-project-headers.hmap -I/Volumes/Data/EWS/WebKit/WebKitBuild/Release/include -IPAL -IForwardingHeaders -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/libxslt -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/libxml2 -I/Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore -I/Volumes/Data/EWS/WebKit/WebKitBuild/Release/usr/local/include -I/Volumes/Data/EWS/WebKit/WebKitBuild/Release/usr/local/include/WebKitAdditions -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/local/include/WebKitAdditions -I/Volumes/Data/EWS/WebKit/WebKitBuild/Release/usr/local/include/webrtc -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/local/include/webrtc -I/Volumes/Data/EWS/WebKit/WebKitBuild/Release/usr/local/include/webrtc/sdk/objc/Framework/Headers -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/local/include/webrtc/sdk/objc/Framework/Headers -I/Volumes/Data/EWS/WebKit/Source/WebCore -I/Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/DerivedSources/x86_64 -I/Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/DerivedSources -Wall -Wextra -Wcast-qual -Wchar-subscripts -Wextra-tokens -Wformat=2 -Winit-self -Wmissing-format-attribute -Wmissing-noreturn -Wpacked -Wpointer-arith -Wredundant-decls -Wundef -Wwrite-strings -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare -Wimplicit-fallthrough -Wno-unknown-warning-option -F/Volumes/Data/EWS/WebKit/WebKitBuild/Release -iframework /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/System/Library/PrivateFrameworks -iframework /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/System/Library/Frameworks -isystem /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/System/Library/Frameworks/System.framework/PrivateHeaders -include /Volumes/Data/EWS/WebKit/WebKitBuild/PrecompiledHeaders/WebCorePrefix-btiiqibcgudtpwgyjrdykupylayh/WebCorePrefix.h -MMD -MT dependencies -MF /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/UnifiedSource100.d --serialize-diagnostics /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/UnifiedSource100.dia -c /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource100.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/UnifiedSource100.o ** BUILD FAILED ** The following build commands failed: CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/UnifiedSource88.o /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource88.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (1 failure) Full output: https://webkit-queues.webkit.org/results/12974748

Said Abou-Hallawa

Comment 16 2019-08-27 18:29:26 PDT

Created attachment 377413 [details] Patch

WebKit Commit Bot

Comment 17 2019-08-28 00:10:50 PDT

Comment on attachment 377413 [details] Patch Clearing flags on attachment: 377413 Committed r249191: <https://trac.webkit.org/changeset/249191>

WebKit Commit Bot

Comment 18 2019-08-28 00:10:51 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 19 2019-08-28 00:11:25 PDT

<rdar://problem/54780300>

Note You need to log in before you can comment on or make changes to this bug.