Bug 196083

Summary: Remove the SVG tear off objects for SVGLength, SVGLengthList and SVGAnimatedLengthList
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: SVGAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jonlee, simon.fraser, sroberts, webkit-bug-importer, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 191237    
Attachments:
Description Flags
Patch
none
Patch none

Said Abou-Hallawa
Reported 2019-03-21 10:14:23 PDT
This is part of removing the tear off objects of the SVG properties.
Attachments
Patch (282.87 KB, patch)
2019-03-25 14:21 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (280.77 KB, patch)
2019-03-26 11:57 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-03-21 13:42:18 PDT
<rdar://problem/49121836>
Said Abou-Hallawa
Comment 2 2019-03-25 14:21:28 PDT
Created attachment 365900 [details] Patch
Said Abou-Hallawa
Comment 3 2019-03-26 11:57:46 PDT
Created attachment 365981 [details] Patch
WebKit Commit Bot
Comment 4 2019-03-26 13:14:40 PDT
Comment on attachment 365981 [details] Patch Clearing flags on attachment: 365981 Committed r243515: <https://trac.webkit.org/changeset/243515>
WebKit Commit Bot
Comment 5 2019-03-26 13:14:42 PDT
All reviewed patches have been landed. Closing bug.
Shawn Roberts
Comment 6 2019-03-26 17:19:20 PDT
It looks like https://trac.webkit.org/changeset/243515 is causing windows 10 build failures. https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Build%29/builds/3228 https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Build%29/builds/3228/steps/compile-webkit/logs/stdio Please let me know if it's a quick fix or we can roll out if you need more time?
Said Abou-Hallawa
Comment 7 2019-03-26 18:06:20 PDT
Windows build fix: <https://trac.webkit.org/changeset/243532>
Note You need to log in before you can comment on or make changes to this bug.