Bug 195008

Summary: Support Pointer Events on macOS
Product: WebKit Reporter: Antoine Quint <graouts>
Component: DOMAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cmarcelo, commit-queue, dbates, dino, esprehn+autocc, ews-watchlist, kangil.han, keith_miller, mark.lam, msaboff, rniwa, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=195098
https://bugs.webkit.org/show_bug.cgi?id=202789
Attachments:
Description Flags
EWS run, not for review
none
Patch
none
Archive of layout-test-results from ews113 for mac-highsierra
none
Archive of layout-test-results from ews101 for mac-highsierra
none
Patch none

Antoine Quint
Reported 2019-02-25 10:51:45 PST
We currently only support Pointer Events on iOS, we need to make them work with the mouse on macOS too.
Attachments
EWS run, not for review (20.05 KB, patch)
2019-02-25 10:54 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (41.41 KB, patch)
2019-02-26 10:27 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews113 for mac-highsierra (410.44 KB, application/zip)
2019-02-26 11:39 PST, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews101 for mac-highsierra (2.46 MB, application/zip)
2019-02-26 11:47 PST, EWS Watchlist 		no flags
Details
Patch (48.15 KB, patch)
2019-02-27 08:32 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2019-02-25 10:51:55 PST
<rdar://problem/47454419>
Antoine Quint
Comment 2 2019-02-25 10:54:21 PST
Created attachment 362911 [details] EWS run, not for review
EWS Watchlist
Comment 3 2019-02-25 10:57:34 PST
Attachment 362911 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Antoine Quint
Comment 4 2019-02-26 10:27:35 PST
Created attachment 362992 [details] Patch
EWS Watchlist
Comment 5 2019-02-26 11:39:33 PST
Comment on attachment 362992 [details] Patch Attachment 362992 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11291951 Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 6 2019-02-26 11:39:34 PST
Created attachment 362997 [details] Archive of layout-test-results from ews113 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-highsierra Platform: Mac OS X 10.13.6
EWS Watchlist
Comment 7 2019-02-26 11:47:09 PST
Comment on attachment 362992 [details] Patch Attachment 362992 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11292065 New failing tests: pointerevents/mouse/pointerdown-prevent-default.html pointerevents/mouse/pointer-events-before-mouse-events.html pointerevents/mouse/pointer-capture.html pointerevents/mouse/over-enter-out-leave.html
EWS Watchlist
Comment 8 2019-02-26 11:47:11 PST
Created attachment 362998 [details] Archive of layout-test-results from ews101 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6
Antoine Quint
Comment 9 2019-02-27 08:14:48 PST
The failures on the WK1 bots are due to two things: 1. the Pointer Events runtime flag wasn't set to true in DumpRenderTree 2. the window.eventSender APIs behave differently in WK1 and make the tests fail (see webkit.org/b/195098)
Antoine Quint
Comment 10 2019-02-27 08:32:49 PST
Created attachment 363092 [details] Patch
Antoine Quint
Comment 11 2019-02-27 08:45:42 PST
The new patch ensures DRT runs with the Pointer Events flag set to true, just like WKTR, and fixes crashers in debug mode due to the default pointerId being to set to 0.
WebKit Commit Bot
Comment 12 2019-02-27 11:02:09 PST
Comment on attachment 363092 [details] Patch Clearing flags on attachment: 363092 Committed r242137: <https://trac.webkit.org/changeset/242137>
WebKit Commit Bot
Comment 13 2019-02-27 11:02:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.