Bug 191977

Summary: Web Inspector: Table selection should be handled by a SelectionController
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, rniwa, webkit-bug-importer
Priority: P3 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 191483    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews102 for mac-sierra
none
Archive of layout-test-results from ews105 for mac-sierra-wk2
none
Archive of layout-test-results from ews115 for mac-sierra
none
Patch
none
Patch none

Matt Baker
Reported 2018-11-26 12:36:58 PST
Summary: Table selection should be handled by a SelectionController. This is a step toward adding multiple-selection to TreeOutline in https://webkit.org/b/191483. Notes: The controller and its delegate (a Table or TreeOutline): class SelectionController { constructor(delegate) get allowsMultipleSelection() set allowsMultipleSelection(flag) get lastSelectedItem() get selectedItems() get numberOfItems() hasSelectedItem(index) selectItem(index, extendSelection = false) deselectItem(index) selectAll() deselectAll() removeSelectedItems() clear() didInsertItem(index); didRemoveItem(index); handleKeyDown(event) handleItemMouseDown(index, event) } class SelectionControllerDelegate { // Required selectionControllerNumberOfItems(controller) selectionControllerNextSelectableIndex(controller, index) selectionControllerPreviousSelectableIndex(controller, index) // Optional selectionControllerSelectionDidChange(controller, deselectedItems, selectedItems) }
Attachments
Patch (34.17 KB, patch)
2018-11-26 13:00 PST, Matt Baker
no flags
Archive of layout-test-results from ews102 for mac-sierra (2.51 MB, application/zip)
2018-11-26 14:02 PST, EWS Watchlist
no flags
Archive of layout-test-results from ews105 for mac-sierra-wk2 (3.49 MB, application/zip)
2018-11-26 14:14 PST, EWS Watchlist
no flags
Archive of layout-test-results from ews115 for mac-sierra (2.21 MB, application/zip)
2018-11-26 14:55 PST, EWS Watchlist
no flags
Patch (36.96 KB, patch)
2018-11-27 08:40 PST, Matt Baker
no flags