Bug 191063

Summary: Static global 'fastHandlerInstalled' conditionally declared in WasmFaultSignalHandler.cpp
Product: WebKit Reporter: Jim Mason <jmason>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jim Mason
Reported 2018-10-30 05:10:17 PDT
The static global variable 'fastHandlerInstalled' is declared inside an #if block in WasmFaultSignalHandler.cpp, but referenced later outside it. This results in a compilation error when the #if condition is not met. In this specific case, the combination of conditions which result in the error are ENABLE(WEBASSEMBLY) and !ENABLE(WEBASSEMBLY_FAST_MEMORY). Rescoping the declaration outside the #if block resolves the problem.
Attachments
Patch (1.36 KB, patch)
2018-10-30 05:22 PDT, Jim Mason 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jim Mason
Comment 1 2018-10-30 05:22:42 PDT
Created attachment 353362 [details] Patch
Yusuke Suzuki
Comment 2 2018-10-30 05:30:51 PDT
Comment on attachment 353362 [details] Patch r=me
Jim Mason
Comment 3 2018-10-31 02:22:11 PDT
Closed by mistake. Reopening for commit bot.
WebKit Commit Bot
Comment 4 2018-10-31 03:10:04 PDT
The commit-queue encountered the following flaky tests while processing attachment 353362 [details]: http/wpt/css/css-animations/start-animation-001.html bug 190903 (authors: dino@apple.com, fred.wang@free.fr, and graouts@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2018-10-31 03:10:53 PDT
Comment on attachment 353362 [details] Patch Clearing flags on attachment: 353362 Committed r237630: <https://trac.webkit.org/changeset/237630>
WebKit Commit Bot
Comment 6 2018-10-31 03:10:55 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-10-31 03:12:38 PDT
<rdar://problem/45696235>
Note You need to log in before you can comment on or make changes to this bug.