Bug 190677

Summary: [GStreamer] Do not sync libwerbtc stream on the clock
Product: WebKit Reporter: Thibault Saunier <tsaunier>
Component: New BugsAssignee: Thibault Saunier <tsaunier>
Status: RESOLVED FIXED    
Severity: Normal CC: alex, commit-queue, pnormand, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 190676    
Bug Blocks: 187064, 190678    
Attachments:
Description Flags
Patch
none
Patch none

Thibault Saunier
Reported 2018-10-17 12:12:21 PDT
[GStreamer] Do not sync libwerbtc stream on the clock
Attachments
Patch (3.91 KB, patch)
2018-10-17 12:15 PDT, Thibault Saunier 		no flags
DetailsFormatted DiffDiff
Patch (3.92 KB, patch)
2018-10-31 04:25 PDT, Thibault Saunier 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Thibault Saunier
Comment 1 2018-10-17 12:15:37 PDT
Created attachment 352608 [details] Patch
Philippe Normand
Comment 2 2018-10-18 02:30:07 PDT
Comment on attachment 352608 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352608&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:250 > +static void setSyncOnSink(GstElement *element, bool sync) Misplaced *. Also sorry for being nitpicky about the name, may I suggest setSyncPropertyOnSink ?
Thibault Saunier
Comment 3 2018-10-18 05:33:27 PDT
(In reply to Philippe Normand from comment #2) > Comment on attachment 352608 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=352608&action=review > > > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:250 > > +static void setSyncOnSink(GstElement *element, bool sync) > > Misplaced *. Also sorry for being nitpicky about the name, may I suggest > setSyncPropertyOnSink ? I do not get when the style checkers report this issue and when not (looks like there is a bug :-). What about `setSyncOnClock()` ?
Philippe Normand
Comment 4 2018-10-18 05:38:08 PDT
(In reply to Thibault Saunier from comment #3) > (In reply to Philippe Normand from comment #2) > > Comment on attachment 352608 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=352608&action=review > > > > > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:250 > > > +static void setSyncOnSink(GstElement *element, bool sync) > > > > Misplaced *. Also sorry for being nitpicky about the name, may I suggest > > setSyncPropertyOnSink ? > > I do not get when the style checkers report this issue and when not (looks > like there is a bug :-). > > What about `setSyncOnClock()` ? OK
Thibault Saunier
Comment 5 2018-10-31 04:25:42 PDT
Created attachment 353487 [details] Patch Renamed syncOnSink to syncOnClock
WebKit Commit Bot
Comment 6 2018-11-05 06:50:37 PST
Comment on attachment 353487 [details] Patch Clearing flags on attachment: 353487 Committed r237799: <https://trac.webkit.org/changeset/237799>
WebKit Commit Bot
Comment 7 2018-11-05 06:50:38 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-11-05 06:51:25 PST
<rdar://problem/45806287>
Note You need to log in before you can comment on or make changes to this bug.