Bug 190100

Summary: Web Inspector: Table with no selection should select the first/last row on down/up arrow key
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P4 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 189718, 190993    
Bug Blocks:    
Attachments:
Description Flags
WIP
none
Patch
none
Patch
none
Patch for landing none

Matt Baker
Reported 2018-09-28 17:04:26 PDT
Summary: Table with no selected row should select the first/last row on down/up arrow key. This improves behavior parity with macOS tables (Finder, Instruments, AppKit's NSTableView, etc). Steps to Reproduce: 1. Open Network tab 2. Focus the table without selecting a row (click past the last row) 3. Press down (or up) arrow key Actual: => Nothing happens Expected: => First (or last) row is selected
Attachments
WIP (2.24 KB, patch)
2018-09-28 17:12 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
Patch (3.70 KB, patch)
2018-11-08 12:39 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
Patch (3.78 KB, patch)
2018-11-13 08:46 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.74 KB, patch)
2018-11-13 11:04 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-09-28 17:04:48 PDT
<rdar://problem/44879243>
Matt Baker
Comment 2 2018-09-28 17:12:22 PDT
Created attachment 351147 [details] WIP
Matt Baker
Comment 3 2018-09-28 17:13:30 PDT
(In reply to Matt Baker from comment #2) > Created attachment 351147 [details] > WIP Lacks support for when the first or last row is not in the cache.
Matt Baker
Comment 4 2018-11-08 12:39:33 PST
Created attachment 354264 [details] Patch
Matt Baker
Comment 5 2018-11-13 08:46:42 PST
Created attachment 354672 [details] Patch
Devin Rousso
Comment 6 2018-11-13 09:54:10 PST
Comment on attachment 354672 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354672&action=review r=me > Source/WebInspectorUI/UserInterface/Views/Table.js:454 > + this.needsLayout(); If we wait for a layout rAF, we'll end up flashing content as we will scroll before the new content is visible. I think this should be `updateLayout` if the row isn't currently visible, but it can stay as is for rows that are. > Source/WebInspectorUI/UserInterface/Views/Table.js:1304 > + if (event.metaKey || event.ctrlKey) > return; Duplicate of next line. Please remove.
Matt Baker
Comment 7 2018-11-13 11:04:10 PST
Created attachment 354682 [details] Patch for landing
WebKit Commit Bot
Comment 8 2018-11-13 11:41:46 PST
Comment on attachment 354682 [details] Patch for landing Clearing flags on attachment: 354682 Committed r238139: <https://trac.webkit.org/changeset/238139>
WebKit Commit Bot
Comment 9 2018-11-13 11:41:48 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.