Bug 188720

Summary: Pass in IsComposed flag to Event constructors
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, ews-watchlist, sam, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 188692, 188777    
Bug Blocks: 170211    
Attachments:
Description Flags
WIP
ews-watchlist: commit-queue-
Archive of layout-test-results from ews203 for win-future
none
WIP2
none
Cleanup
none
Fixed iOS builds none

Ryosuke Niwa
Reported 2018-08-18 01:28:23 PDT
Right now, Event::isComposed() implements the check for composed events. We should be setting them in constructors like CanBubble and IsCancelable.
Attachments
WIP (34.31 KB, patch)
2018-08-18 01:30 PDT, Ryosuke Niwa 		ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews203 for win-future (12.90 MB, application/zip)
2018-08-18 10:54 PDT, EWS Watchlist 		no flags
Details
WIP2 (44.90 KB, patch)
2018-08-22 23:42 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Cleanup (58.12 KB, patch)
2018-08-23 21:12 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Fixed iOS builds (60.35 KB, patch)
2018-08-23 22:23 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2018-08-18 01:30:30 PDT
Created attachment 347439 [details] WIP
EWS Watchlist
Comment 2 2018-08-18 01:33:30 PDT
Attachment 347439 [details] did not pass style-queue: ERROR: Source/WebCore/dom/WheelEvent.cpp:51: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/dom/UIEventWithKeyState.h:45: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/dom/UIEventWithKeyState.h:56: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/dom/UIEventWithKeyState.h:57: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/dom/UIEventWithKeyState.h:58: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/dom/UIEventWithKeyState.h:59: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/dom/UIEventWithKeyState.h:60: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/dom/UIEventWithKeyState.h:61: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/dom/UIEventWithKeyState.h:62: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseRelatedEvent.h:83: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseRelatedEvent.h:83: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/dom/MouseEvent.cpp:90: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseEvent.cpp:90: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseEvent.cpp:90: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/dom/KeyboardEvent.cpp:97: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:43: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:43: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 17 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.
EWS Watchlist
Comment 3 2018-08-18 10:54:17 PDT
Comment on attachment 347439 [details] WIP Attachment 347439 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8902172 New failing tests: fast/workers/worker-exception-during-navigation.html legacy-animation-engine/imported/blink/transitions/unprefixed-transform.html
EWS Watchlist
Comment 4 2018-08-18 10:54:31 PDT
Created attachment 347447 [details] Archive of layout-test-results from ews203 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews203 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Radar WebKit Bug Importer
Comment 5 2018-08-21 15:23:58 PDT
<rdar://problem/43580387>
Ryosuke Niwa
Comment 6 2018-08-22 23:42:50 PDT
Created attachment 347910 [details] WIP2
EWS Watchlist
Comment 7 2018-08-22 23:44:44 PDT
Attachment 347910 [details] did not pass style-queue: ERROR: Source/WebCore/dom/UIEventWithKeyState.h:50: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/dom/UIEventWithKeyState.h:57: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseEvent.cpp:84: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseEvent.cpp:84: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/dom/SimulatedClick.cpp:48: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/dom/KeyboardEvent.cpp:97: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:39: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:39: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 8 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ryosuke Niwa
Comment 8 2018-08-23 21:12:49 PDT
Created attachment 347986 [details] Cleanup
EWS Watchlist
Comment 9 2018-08-23 21:16:00 PDT
Attachment 347986 [details] did not pass style-queue: ERROR: Source/WebCore/dom/UIEventWithKeyState.h:50: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/dom/UIEventWithKeyState.h:57: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseEvent.cpp:84: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseEvent.cpp:84: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/dom/SimulatedClick.cpp:48: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/dom/KeyboardEvent.cpp:97: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:39: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:39: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 8 in 34 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ryosuke Niwa
Comment 10 2018-08-23 22:23:10 PDT
Created attachment 347990 [details] Fixed iOS builds
EWS Watchlist
Comment 11 2018-08-23 22:25:27 PDT
Attachment 347990 [details] did not pass style-queue: ERROR: Source/WebCore/dom/UIEventWithKeyState.h:50: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/dom/UIEventWithKeyState.h:57: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseEvent.cpp:84: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseEvent.cpp:84: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/dom/SimulatedClick.cpp:48: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/dom/KeyboardEvent.cpp:97: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:39: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:39: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 8 in 34 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ryosuke Niwa
Comment 12 2018-08-24 13:14:52 PDT
Comment on attachment 347990 [details] Fixed iOS builds Clearing flags on attachment: 347990 Committed r235331: <https://trac.webkit.org/changeset/235331>
Ryosuke Niwa
Comment 13 2018-08-24 13:14:53 PDT
All reviewed patches have been landed. Closing bug.
Lucas Forschler
Comment 14 2019-02-06 09:18:56 PST
Mass move bugs into the DOM component.
Note You need to log in before you can comment on or make changes to this bug.